release gcb-docker-gcloud as a releng image - #4481
Conversation
|
/cc @xmudrii |
|
/hold I need to add the postsubmit once the change is approved |
|
/priority critical/urgent |
|
@upodroid: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f90fb86 to
e8e5a97
Compare
e8e5a97 to
e4d7d6e
Compare
e4d7d6e to
cf21338
Compare
|
I addressed all the comments |
BenTheElder
left a comment
There was a problem hiding this comment.
@upodroid you might consider adding an owners file with at least yourself for future patching, if not comparable owners to the previous source location ... so we can expedite future reviews
cf21338 to
ae368ab
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Migrate to the registry.k8s.io/releng/gcb-docker-gcloud as part of the general move mentioned here github.com/kubernetes/release/pull/4481 Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
See kubernetes/release#4481 for the reference. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
What type of PR is this?
/kind feature
What this PR does / why we need it:
I want to release https://github.com/kubernetes/test-infra/tree/master/images/gcb-docker-gcloud to registry.k8s.io.
gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20260127-c1affcc8dewill now be pulled asregistry.k8s.io/releng/gcb-docker-gcloud:v20260127In order to do this, I need to transfer the image to this repo and build it out of here. I'm also going to use this opportunity to make a breaking change and drop https://github.com/kubernetes/test-infra/blob/058c26adcd251f37a719a96b39a458660a14f974/images/gcb-docker-gcloud/buildx-entrypoint.sh this script and ask users to update their cloudbuild files like this.
The only guarantee this image makes is that go, gcloud, and docker always work with Google Cloud Build.
Which issue(s) this PR fixes:
Fixes kubernetes/k8s.io#9599
Special notes for your reviewer:
Does this PR introduce a user-facing change?