Sync supported service account token algorithms to test image - #141012
Conversation
|
Please note that we're already in Code Freeze for the upcoming v1.37.0 release. Adding the milestone to this PR is strictly prohibited without proper approval. If this PR needs to be included in the v1.37.0 release:
|
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve @liggitt should we add the milestone? since it is breaking external folks running conformance cc @kubernetes/release-team-leads |
|
LGTM label has been added. DetailsGit tree hash: d29a6005cb7ec2516d3e17b4b335ab410689f3fc |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'd be supportive of that (and actually of backporting a test-only change like this) @kubernetes/release-managers @kubernetes/cncf-conformance-wg thoughts? |
|
Let's do this! we are just adding additional entries and no change in logic. /milestone v1.37 |
|
thanks ... it's been a while since I've bumped agnhost ... do we have to trigger a build / release / bump ourselves? |
|
https://prow.k8s.io/?job=*agnhost* should have worked, but that's facing a different problem w.r.t gcb-docker-gcloud that @upodroid is chasing in kubernetes/release#4481 |
|
do we need to bump an agnhost version in test/images/agnhost/VERSION before that will trigger a new build, or does it build automatically from master and we just have to promote a build to a tag? |
|
is there additional work needed to make this work on 1.36? There was a previous comment about backporting the change. |
What type of PR is this?
/kind cleanup
/kind failing-test
What this PR does / why we need it:
Updates the test image to support all the algorithms we support for signing service account tokens.
Which issue(s) this PR is related to:
#141010
Does this PR introduce a user-facing change?
/sig auth testing