Skip to content

Sync supported service account token algorithms to test image - #141012

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
liggitt:sync-algorithms
Jul 29, 2026
Merged

Sync supported service account token algorithms to test image#141012
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
liggitt:sync-algorithms

Conversation

@liggitt

@liggitt liggitt commented Jul 28, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

Updates the test image to support all the algorithms we support for signing service account tokens.

Which issue(s) this PR is related to:

#141010

Does this PR introduce a user-facing change?

NONE

/sig auth testing

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 28, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Please note that we're already in Code Freeze for the upcoming v1.37.0 release.

Adding the milestone to this PR is strictly prohibited without proper approval. If this PR needs to be included in the v1.37.0 release:

  1. Technical review: get the PR reviewed and approved as usual (/lgtm and /approve)
  2. Inclusion in release: ping @sig-release-leads on the #sig-release Slack channel and suggest to add the v1.37.0 milestone to the PR

@kubernetes-prow kubernetes-prow Bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 28, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mikedanese and mkumatag July 28, 2026 21:02
@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2026
@dims

dims commented Jul 28, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm

@liggitt should we add the milestone? since it is breaking external folks running conformance

cc @kubernetes/release-team-leads

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: d29a6005cb7ec2516d3e17b4b335ab410689f3fc

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

liggitt commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

I'd be supportive of that (and actually of backporting a test-only change like this)

@kubernetes/release-managers @kubernetes/cncf-conformance-wg thoughts?

@liggitt
liggitt requested review from dims and johnbelamaric and removed request for mikedanese and mkumatag July 28, 2026 22:41
@dims

dims commented Jul 29, 2026

Copy link
Copy Markdown
Member

Let's do this! we are just adding additional entries and no change in logic.

/milestone v1.37

@kubernetes-prow kubernetes-prow Bot added this to the v1.37 milestone Jul 29, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 7fbcad5 into kubernetes:master Jul 29, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this to Closed / Done in SIG Auth Jul 29, 2026
@liggitt

liggitt commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

thanks ... it's been a while since I've bumped agnhost ... do we have to trigger a build / release / bump ourselves?

@dims

dims commented Jul 29, 2026

Copy link
Copy Markdown
Member

https://prow.k8s.io/?job=*agnhost* should have worked, but that's facing a different problem w.r.t gcb-docker-gcloud that @upodroid is chasing in kubernetes/release#4481

@liggitt

liggitt commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

do we need to bump an agnhost version in test/images/agnhost/VERSION before that will trigger a new build, or does it build automatically from master and we just have to promote a build to a tag?

@cbf123

cbf123 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

is there additional work needed to make this work on 1.36? There was a previous comment about backporting the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Closed / Done

Development

Successfully merging this pull request may close these issues.

3 participants