-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix PhysX collision filtering in direct tasks #6855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kellyguo11
wants to merge
2
commits into
isaac-sim:develop
Choose a base branch
from
kellyguo11:kellyguo11/fix-direct-physx-collision-filtering
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
source/isaaclab_tasks/changelog.d/fix-direct-physx-collision-filtering.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed ineffective joint actuation in direct-workflow PhysX environments by filtering collisions between | ||
| replicas on all simulation devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
source/isaaclab_tasks/test/core/test_cartpole_direct_physx_actuation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Copyright (c) 2022-2026, The Isaac Lab Project Developers (https://github.com/isaac-sim/IsaacLab/blob/main/CONTRIBUTORS.md). | ||
| # All rights reserved. | ||
| # | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| """Test PhysX actuation in the direct-workflow Cartpole environment.""" | ||
|
|
||
| from isaaclab.app import AppLauncher | ||
|
|
||
| # launch the simulator | ||
| simulation_app = AppLauncher(headless=True).app | ||
|
|
||
| """Rest everything follows.""" | ||
|
|
||
| import gymnasium as gym | ||
| import pytest | ||
| import torch | ||
|
|
||
| import isaaclab_tasks # noqa: F401 | ||
| from isaaclab_tasks.core.cartpole.cartpole_direct_env_cfg import CartpoleEnvCfg | ||
| from isaaclab_tasks.utils.hydra import resolve_presets | ||
|
|
||
|
|
||
| @pytest.mark.isaacsim_ci | ||
| def test_cartpole_direct_physx_actuation_is_consistent_across_environments(): | ||
| """Verify that cloned PhysX carts respond consistently to a constant effort.""" | ||
| cfg = resolve_presets(CartpoleEnvCfg(), ("physx",)) | ||
| cfg.scene.num_envs = 4 | ||
| cfg.sim.device = "cuda:0" | ||
| cfg.seed = 0 | ||
| cfg.initial_cart_position_range = (0.0, 0.0) | ||
| cfg.initial_cart_velocity_range = (0.0, 0.0) | ||
| cfg.initial_pole_angle_range = (0.0, 0.0) | ||
| cfg.initial_pole_velocity_range = (0.0, 0.0) | ||
|
|
||
| env = gym.make("Isaac-Cartpole-Direct", cfg=cfg) | ||
| try: | ||
| env.reset() | ||
| actions = torch.ones(env.action_space.shape, device=env.unwrapped.device) | ||
| with torch.inference_mode(): | ||
| for _ in range(20): | ||
| env.step(actions) | ||
|
|
||
| cart_idx = env.unwrapped._cart_dof_idx[0] | ||
| cart_vel = env.unwrapped.cartpole.data.joint_vel.torch[:, cart_idx] | ||
| assert torch.all(cart_vel > 1.0), f"Expected every cart to accelerate, got velocities {cart_vel.tolist()}." | ||
| torch.testing.assert_close(cart_vel, cart_vel[0].expand_as(cart_vel)) | ||
| finally: | ||
| env.close() | ||
4 changes: 2 additions & 2 deletions
4
source/isaaclab_tasks/test/golden_stages/cartpole/physx-isaacsim_rtx_renderer-rgb.usda
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
source/isaaclab_tasks/test/golden_stages/cartpole/physx-newton_renderer-rgb.usda
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...registered_tasks_Isaac-Cartpole-Camera-Direct/default_physics-default_renderer-stage.usda
Git LFS file not shown
4 changes: 2 additions & 2 deletions
4
...asks_Isaac-Reorient-Cube-Shadow-Camera-Direct/default_physics-default_renderer-stage.usda
Git LFS file not shown
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test necessary? I think there are other tests (test_environments) that already provide this coverage