Skip to content

[CI] Publish nightly images to the current NGC org - #6837

Open
hujc7 wants to merge 2 commits into
isaac-sim:developfrom
hujc7:jichuanh/publish-target-internal-org
Open

[CI] Publish nightly images to the current NGC org#6837
hujc7 wants to merge 2 commits into
isaac-sim:developfrom
hujc7:jichuanh/publish-target-internal-org

Conversation

@hujc7

@hujc7 hujc7 commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Description

The CI credential no longer has access to nvcr.io/nvidian/isaac-lab, so the nightly
image publish fails on push. That repository is unreachable even anonymously:

Image Anonymous With NGC_API_KEY
nvcr.io/nvidian/isaac-lab:latest-develop denied denied
nvcr.io/0947644777160149/internal/isaac-lab:latest-develop ok

This points isaaclab_image_name at the org Isaac Sim already publishes from, which is
the same org this branch pulls its base image from after #6815. Reading and publishing
now happen in one place instead of straddling a mirror that no longer receives builds.

isaacsim_image_name and isaacsim_image_tag are untouched; every workflow already
resolves the publish target through config.yaml, so no workflow changes are needed.

Follow-up to #6815.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Screenshots

None.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Notes

Push access to the new repository is unverified — only pull was probed. The first
scheduled publish after this merges is the real confirmation.

docs/source/features/include/docker_details.inc still points readers at
nvcr.io/nvidian/isaac-lab:latest-develop-kitless, which is both an unreachable org and
a tag that does not exist. Left for a separate docs change.

The CI credential no longer has access to nvcr.io/nvidian/isaac-lab, so
the nightly image publish fails on push. That repository is unreachable
even anonymously, while the org Isaac Sim now publishes from is readable
with the same credential.

Point the publish target at that org so it matches the base image the
branch already builds on.
@github-actions github-actions Bot added isaac-lab Related to Isaac Lab team infrastructure labels Aug 1, 2026
@hujc7
hujc7 marked this pull request as ready for review August 1, 2026 17:53
@hujc7
hujc7 requested a review from a team August 1, 2026 17:53

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The PR centralizes the nightly Isaac Lab image target on nvcr.io/0947644777160149/internal/isaac-lab and records the CI-only change with a no-bump changelog fragment.

  • Design and architecture: Using the existing shared isaaclab_image_name configuration key preserves centralized image resolution and aligns the Isaac Lab publish location with the NGC organization used for Isaac Sim. Push authorization remains an operational risk because only pull access has been verified.
  • API: No public Python or extension API changes. The CI configuration key retains the same name and scalar shape, limiting compatibility impact to the intended registry destination change.
  • Implementation: The YAML value change is narrowly scoped, and the .skip fragment follows the repository convention for CI-only changes. The existing config comment describes only the Isaac Sim mirror history, while separate documentation still references the obsolete Isaac Lab image path; these are non-blocking documentation consistency concerns rather than demonstrated failures in this patch.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR redirects nightly IsaacLab image publishing from the inaccessible nvidian repository to the numeric NGC organization already used for Isaac Sim images.

  • Updates the shared isaaclab_image_name workflow configuration.
  • Adds a CI-only changelog fragment documenting the publishing-target correction.

Confidence Score: 5/5

The PR appears safe to merge based on the repository-visible configuration and workflow behavior.

The changed configuration is consumed as a complete image prefix by the publishing workflow, and no path-shape, tag-composition, or authentication regression is established; actual write authorization remains an explicitly acknowledged external deployment check.

Important Files Changed

Filename Overview
.github/workflows/config.yaml Repoints the shared IsaacLab image target to nvcr.io/0947644777160149/internal/isaac-lab; no repository-visible defect was established.
source/isaaclab/changelog.d/jichuanh-publish-target-internal-org.skip Adds an accurate CI-only changelog entry for the registry-target change.

Reviews (1): Last reviewed commit: "Merge branch 'develop' into jichuanh/pub..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants