[CI] Publish nightly images to the current NGC org - #6837
Conversation
The CI credential no longer has access to nvcr.io/nvidian/isaac-lab, so the nightly image publish fails on push. That repository is unreachable even anonymously, while the org Isaac Sim now publishes from is readable with the same credential. Point the publish target at that org so it matches the base image the branch already builds on.
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR centralizes the nightly Isaac Lab image target on nvcr.io/0947644777160149/internal/isaac-lab and records the CI-only change with a no-bump changelog fragment.
- Design and architecture: Using the existing shared
isaaclab_image_nameconfiguration key preserves centralized image resolution and aligns the Isaac Lab publish location with the NGC organization used for Isaac Sim. Push authorization remains an operational risk because only pull access has been verified. - API: No public Python or extension API changes. The CI configuration key retains the same name and scalar shape, limiting compatibility impact to the intended registry destination change.
- Implementation: The YAML value change is narrowly scoped, and the
.skipfragment follows the repository convention for CI-only changes. The existing config comment describes only the Isaac Sim mirror history, while separate documentation still references the obsolete Isaac Lab image path; these are non-blocking documentation consistency concerns rather than demonstrated failures in this patch.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryThe PR redirects nightly IsaacLab image publishing from the inaccessible
Confidence Score: 5/5The PR appears safe to merge based on the repository-visible configuration and workflow behavior. The changed configuration is consumed as a complete image prefix by the publishing workflow, and no path-shape, tag-composition, or authentication regression is established; actual write authorization remains an explicitly acknowledged external deployment check. Important Files Changed
Reviews (1): Last reviewed commit: "Merge branch 'develop' into jichuanh/pub..." | Re-trigger Greptile |
Description
The CI credential no longer has access to
nvcr.io/nvidian/isaac-lab, so the nightlyimage publish fails on push. That repository is unreachable even anonymously:
NGC_API_KEYnvcr.io/nvidian/isaac-lab:latest-developnvcr.io/0947644777160149/internal/isaac-lab:latest-developThis points
isaaclab_image_nameat the org Isaac Sim already publishes from, which isthe same org this branch pulls its base image from after #6815. Reading and publishing
now happen in one place instead of straddling a mirror that no longer receives builds.
isaacsim_image_nameandisaacsim_image_tagare untouched; every workflow alreadyresolves the publish target through
config.yaml, so no workflow changes are needed.Follow-up to #6815.
Type of change
Screenshots
None.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists thereNotes
Push access to the new repository is unverified — only pull was probed. The first
scheduled publish after this merges is the real confirmation.
docs/source/features/include/docker_details.incstill points readers atnvcr.io/nvidian/isaac-lab:latest-develop-kitless, which is both an unreachable org anda tag that does not exist. Left for a separate docs change.