Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
7 changes: 3 additions & 4 deletions source/isaaclab/isaaclab/cloner/_fabric_notices.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@
framework so cloning can suspend Fabric's USD notice listener without depending on
``isaacsim.core.simulation_manager``.

Mirrors the in-tree pattern in :mod:`isaaclab_newton.physics._cubric` for
``omni::cubric::IAdapter`` — same problem (base-Kit Carbonite interface with no
Python binding), same solution. When Kit exposes this from Python, replace this
module with a one-line import.
This is a temporary shim for a base-Kit Carbonite interface that has no Python
binding yet. When Kit exposes this from Python, replace this module with a
one-line import.
"""

from __future__ import annotations
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Changed
^^^^^^^

* Changed Newton Kit viewport transform sync to call
``IFabricHierarchy.update_world_xforms_gpu_with_options`` with
``FabricHierarchyGpuUpdateOptions.RIGID_BODY | FORCE_UPDATE`` instead of the
private ctypes ``omni::cubric::IAdapter`` shim. Older Kit builds without the
new API continue to fall back to ``IFabricHierarchy.update_world_xforms``.

Removed
^^^^^^^

* Removed :mod:`isaaclab_newton.physics._cubric` ctypes bindings for

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Suggestion · Api — Changelog exposes private module removal

The Removed entry announces :mod:isaaclab_newton.physics._cubric``, a private module that was never user-facing, and the :mod: role now points at a deleted target. Repository changelog guidance asks to avoid internal implementation details users would not understand; fold the user-visible behavior into the existing `Changed` entry and drop the private-module removal.

``omni::cubric::IAdapter``. Use
``IFabricHierarchy.update_world_xforms_gpu_with_options`` instead.
357 changes: 0 additions & 357 deletions source/isaaclab_newton/isaaclab_newton/physics/_cubric.py

This file was deleted.

Loading
Loading