Skip to content

[Newton] Drop the unused lockfile input from the kit-less build - #6823

Draft
hujc7 wants to merge 1 commit into
isaac-sim:developfrom
hujc7:jichuanh/kitless-docs-followup
Draft

[Newton] Drop the unused lockfile input from the kit-less build#6823
hujc7 wants to merge 1 commit into
isaac-sim:developfrom
hujc7:jichuanh/kitless-docs-followup

Conversation

@hujc7

@hujc7 hujc7 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

1. Summary

  • Stops copying uv.lock into the kit-less build context, and stops gating the kit-less CI job on it.
  • Two files, +1 / -2.

2. Background

#6355 — "[Newton] Add a kitless training container" — installs through "${ISAACLAB_PATH}/isaaclab.sh" --install newton,rl[all],ov[ovrtx], matching Dockerfile.base and Dockerfile.curobo. That path goes through uv pip, which does not read uv.lock; there is no uv sync or --frozen left in the Dockerfile.

3. Details

uv.lock was still copied in the same layer as pyproject.toml. Nothing reads it, but a COPY makes a file part of the build cache key regardless, so every lockfile change invalidated that layer and forced a full dependency reinstall.

The workflow's change-detection pattern had the same problem in reverse: a lockfile-only change triggered a GPU build that could not produce a different image.

pyproject.toml and the per-package manifests still gate the build, which is what uv pip install --editable actually resolves from.

4. Test plan

  • Confirmed nothing in isaaclab.sh, the install CLI, Dockerfile.kitless or validate-kitless-image reads uv.lock, uv sync, uv run or --frozen.
  • docker/test/test_container_profiles.py + docker/test/test_dockerfile_nonroot.py: 30 passed.
  • uv run isaaclab -f on all files.
  • tools/changelog/cli.py check — no source/<pkg>/ touched, no fragment required.

@github-actions github-actions Bot added documentation Improvements or additions to documentation infrastructure labels Jul 31, 2026
Nothing in the kit-less image reads uv.lock: the build installs through
isaaclab.sh, which resolves dependencies with uv pip. The file was still
copied into the build context alongside pyproject.toml, so every lockfile
change invalidated the dependency layer and forced a full reinstall.

Remove it from the COPY and, for the same reason, from the workflow's
change-detection patterns; a lockfile-only change cannot produce a different
image. pyproject.toml and the package manifests still gate the build.
@hujc7
hujc7 force-pushed the jichuanh/kitless-docs-followup branch from 9315d69 to fd29f15 Compare July 31, 2026 08:56
@hujc7 hujc7 changed the title [Newton] Correct kit-less container docs and drop its unused lockfile input [Newton] Drop the unused lockfile input from the kit-less build Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant