Skip to content

Gate legacy kitless rendering on PRs - #6816

Open
nvsekkin wants to merge 3 commits into
isaac-sim:developfrom
nvsekkin:esekkin/gate-kitless-legacy
Open

Gate legacy kitless rendering on PRs#6816
nvsekkin wants to merge 3 commits into
isaac-sim:developfrom
nvsekkin:esekkin/gate-kitless-legacy

Conversation

@nvsekkin

Copy link
Copy Markdown
Collaborator

Description

Makes legacy kitless rendering failures fail PR checks while preserving full test execution; merge after OVPhysX wheelhouse parity is restored.

Preserve complete test execution while allowing legacy failures to produce
a failing check; keep OVStage PR and manual runs non-blocking.
@nvsekkin
nvsekkin marked this pull request as ready for review July 31, 2026 22:18
@nvsekkin
nvsekkin requested a review from a team July 31, 2026 22:18
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR changes CI gating for kitless rendering:

  • Makes the legacy rendering variant blocking on pull requests.
  • Keeps the ovstage variant non-blocking on pull requests.
  • Keeps both variants non-blocking for manually dispatched workflows.

Confidence Score: 5/5

The PR appears safe to merge, with the workflow condition matching the declared rendering-gate behavior.

The matrix contains the expected legacy and ovstage variants, and the new condition correctly makes only legacy failures blocking on pull requests while leaving manual runs non-blocking.

Important Files Changed

Filename Overview
.github/workflows/build.yaml Updates continue-on-error to gate legacy rendering failures on pull requests while preserving the intended non-blocking behavior for OVStage and manual runs.

Reviews (1): Last reviewed commit: "Gate legacy kitless rendering on PRs" | Re-trigger Greptile

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The workflow change makes legacy kitless rendering failures block pull requests while preserving non-blocking manual runs and existing push behavior.

  • Design and architecture: The gating matches the matrix configuration: pull requests exclude the ovstage variant, so legacy is the only kitless variant that becomes blocking on PRs. The separate rendering-correctness job is unaffected.
  • API: No Python, CLI, packaging, or public API surface changes. As this only modifies CI workflow behavior and touches no package, no package changelog fragment is needed.
  • Implementation: The event and matrix paths are consistent: PR legacy runs are blocking, PR ovstage runs remain excluded, both workflow-dispatch variants tolerate failure, and push runs remain blocking. The ovstage PR condition is currently unreachable but remains consistent if the matrix exclusion changes later.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants