Gate legacy kitless rendering on PRs - #6816
Conversation
Preserve complete test execution while allowing legacy failures to produce a failing check; keep OVStage PR and manual runs non-blocking.
Greptile SummaryThe PR changes CI gating for kitless rendering:
Confidence Score: 5/5The PR appears safe to merge, with the workflow condition matching the declared rendering-gate behavior. The matrix contains the expected Important Files Changed
Reviews (1): Last reviewed commit: "Gate legacy kitless rendering on PRs" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
The workflow change makes legacy kitless rendering failures block pull requests while preserving non-blocking manual runs and existing push behavior.
- Design and architecture: The gating matches the matrix configuration: pull requests exclude the
ovstagevariant, solegacyis the only kitless variant that becomes blocking on PRs. The separate rendering-correctness job is unaffected. - API: No Python, CLI, packaging, or public API surface changes. As this only modifies CI workflow behavior and touches no package, no package changelog fragment is needed.
- Implementation: The event and matrix paths are consistent: PR
legacyruns are blocking, PRovstageruns remain excluded, both workflow-dispatch variants tolerate failure, and push runs remain blocking. TheovstagePR condition is currently unreachable but remains consistent if the matrix exclusion changes later.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Description
Makes legacy kitless rendering failures fail PR checks while preserving full test execution; merge after OVPhysX wheelhouse parity is restored.