Update the template generator for RSL-RL - #6806
Conversation
| {% set runner_prefix = {"distillation": "Distillation"}.get(algorithm, algorithm|upper) %} | ||
| {% set agent_config = "." ~ rl_library.name ~ "_" ~ algorithm ~ "_cfg:" ~ runner_prefix ~ "RunnerCfg" %} |
There was a problem hiding this comment.
Distillation default entry point missing
When a project is generated with RSL-RL Distillation but without PPO, registration exposes only rsl_rl_distillation_cfg_entry_point, while the standard train and play commands request rsl_rl_cfg_entry_point, causing configuration loading to fail with Could not find configuration for the environment.
|
|
||
| # RL algorithms | ||
| SINGLE_AGENT_ALGORITHMS = ["AMP", "PPO"] | ||
| SINGLE_AGENT_ALGORITHMS = ["AMP", "PPO", "DISTILLATION"] |
There was a problem hiding this comment.
Greptile SummaryThe PR extends generated RSL-RL projects with Distillation and updates their configuration templates for RSL-RL v5.
Confidence Score: 4/5The missing default Distillation entry point and stale test expectations should be fixed before merging. Distillation-only generated projects fail configuration loading through the standard train and play commands, and the changed discovery result breaks checked-in template-generator assertions. Files Needing Attention: tools/template/templates/tasks/__init__task; tools/template/common.py; source/isaaclab_rl/test/test_template_generator.py Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CLI[Template CLI selects RSL-RL Distillation] --> Gen[Generate task and Distillation config]
Gen --> Reg[Register rsl_rl_distillation_cfg_entry_point]
Train[Default train or play command] --> Default[Request rsl_rl_cfg_entry_point]
Default --> Missing[Configuration key absent]
Missing --> Error[Configuration-loading ValueError]
Reviews (1): Last reviewed commit: "fix template for new rsl_rl" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
No material issues were identified in the reviewed diff.
- Design and architecture: No material concerns.
- API: No material concerns.
- Implementation: No material concerns.
Ship it. No actionable findings were identified in the reviewed diff.
Conservative automated review; human maintainers own approval decisions.
|
thanks for this update! could you also update the template generator tests to take into consideration the new changes? |
Cover Distillation in algorithm discovery, generated config files, and registry entry points so the tests match the newly supported RSL-RL workflow.
Description
This PR adds Distillation to the list of available algorithms for RSL-RL. It also updates the config templates to RSL-RL version 5. This is a reimplementation of #5117 but now targeting develop.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --format