fix: allow clients to panic NPCs - #255
Merged
Merged
Conversation
3 tasks
ifBars
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @ifBars in #245.
Diffuin response
Confidence: Medium
NPC.Panic() now delegates directly to the native panic ServerRpc instead of silently returning for non-host clients. The public method shape is unchanged, and focused managed/native method-shape tests were added. PR creation is left to delivery automation.
Recommended next steps
Evidence and validation
Evidence inspected
Validation performed
Runtime validation remaining
Diffuin run details
gpt-5.6-terrahigh(source-backed technical request)019feebd-0b32-7aa0-99e2-d6ca894edd9cAI notice: Generated with AI assistance and not guaranteed accurate. Verify findings and plans against the current source and runtime.
Closes #245
Diffuin job:
6068670d-e18a-4be3-b1f9-4d94681228cfCommit:
5658509fd46586b198c39d6cbbc4e7447481422f