[BUG] NPC.Panic silently does nothing for non-host clients

[ifBars]

Summary

NPC.Panic() returns immediately when called by a non-host client, even though the native SetPanicked_Server method is a client-callable ServerRpc.

Game Version

Other: current regular and alternate game assemblies inspected on August 10, 2026.

S1API Version

3.1.12 / current stable source.

MelonLoader Version

Not runtime-specific; confirmed from current S1API and native method metadata.

Runtime Environment

Mono (Alternate) and IL2CPP (Regular).

Steps to Reproduce

1. Join a multiplayer game as a non-host client.
2. Resolve an NPC through S1API.
3. Call npc.Panic().
4. Observe that S1API returns before invoking the native ServerRpc.

Expected vs Actual Behavior

Expected: The native SetPanicked_Server RPC is invoked and the server applies the panic state.

Actual: S1API's SafeIsServer() guard makes the call a silent no-op for non-host clients.

MelonLoader Log

No exception or warning is produced; the method returns silently.

What Have You Tried?

Reviewed current S1API control flow and the current Mono/IL2CPP native surfaces. SetPanicked_Server remains a ServerRpc with RequireOwnership = false and RunLocally = true.

Additional Context

Remove or narrow the redundant S1API guard and test host, remote-client, and dedicated-server calls in both runtimes.

Pre-submission Checklist

• I have read the installation guide
• I am using the latest version of S1API
• I have verified this issue is related to S1API

[ifBars]

@Diffuin Create an implementation plan to fix this

[diffuin]

Implementation plan

Summary

The bug is confirmed in NPC.Panic(), which blocks non-server clients before calling the native client-callable ServerRpc. Remove that guard, preserve the public API, add contract coverage, and validate all requested roles on Mono and IL2CPP.

Design decisions

1. Keep the existing public void Panic() signature and delegate directly to the native RPC.
2. Remove the unused SafeIsServer() helper and misleading host-only documentation.
3. Do not add save or persistence changes because panic is transient; validate authority and observer behavior in live multiplayer tests.

Implementation

1. Apply the narrow delegation fix — Allow remote clients to reach the native RPC while preserving host and dedicated-server behavior.
   • Remove the SafeIsServer() check from Panic() and call S1NPC.SetPanicked_Server() directly. (S1API/Entities/NPC.cs)
   • Delete SafeIsServer() if it has no remaining callers. (S1API/Entities/NPC.cs)
   • Update the XML summary so it describes the networked panic request without claiming server-only behavior. (S1API/Entities/NPC.cs)
2. Add focused compatibility coverage — Freeze the public API contract and native method assumptions without simulating FishNet in standalone xUnit tests.
   • Add a test confirming NPC.Panic() remains public, parameterless, and void. (S1API.Tests/Entities/NPCPanicApiCompatibilityTests.cs)
   • Verify the referenced native NPC type still exposes SetPanicked_Server() with its parameterless callable surface under both test configurations. (S1API.Tests/Entities/NPCPanicApiCompatibilityTests.cs, S1API.Tests/S1API.Tests.csproj)
   • Keep save fixtures and persistent-state assertions out of this change because panic is not persisted by S1API. (S1API.Tests/Entities/NPCPanicApiCompatibilityTests.cs)
3. Run repository checks — Confirm both build graphs and the required API compatibility gates.
   • Run dotnet restore S1API.sln -p:Configuration=MonoMelon, build with -c MonoMelon --no-restore -p:AutomateLocalDeployment=false, then run the Mono test suite. (S1API.sln, S1API/S1API.csproj, S1API.Tests/S1API.Tests.csproj)
   • Repeat restore, build, and test with Il2CppMelon using fresh generated wrapper references. (S1API.sln, S1API/S1API.csproj, S1API.Tests/S1API.Tests.csproj)
   • Run the repository's documentation coverage and ApiCompat checks against the exact target branch assembly. (S1API/Entities/NPC.cs, S1API.Tests/Entities/NPCPanicApiCompatibilityTests.cs)
   • Record unchanged source, binary, save, and network contracts, with the behavioral correction limited to previously suppressed remote-client requests. (S1API/Entities/NPC.cs)
4. Validate multiplayer behavior — Prove the RPC path on each requested role and backend in human-owned game installations.
   • On Mono Alternate, call npc.Panic() as host, remote client, and dedicated-server client; confirm server application and observer convergence. (S1API/Entities/NPC.cs)
   • Repeat the host, remote-client, and dedicated-server scenarios on IL2CPP Regular. (S1API/Entities/NPC.cs)
   • Check logs for ownership rejection, RPC exceptions, duplicate local execution, or silent no-ops, and record the results in the pull request. (S1API/Entities/NPC.cs)

Implementation gates

• Confirm the current Regular IL2CPP generated wrapper preserves SetPanicked_Server() with RequireOwnership = false and RunLocally = true; the local stripped evidence establishes this only for Mono.

Evidence and validation

Evidence inspected

• S1API/Entities/NPC.cs:2914-2921 returns when SafeIsServer() is false before calling S1NPC.SetPanicked_Server().
• S1API/Entities/NPC.cs:2627-2637 defines the guard helper, which has no other callers.
• Both supplied alternate Mono sources declare SetPanicked_Server() as [ServerRpc(RequireOwnership = false, RunLocally = true)], followed by an observer panic method.
• S1API/Cartel/Cartel.cs:113-122 shows the repository pattern of directly invoking a native server RPC without an S1API server guard.

Validation performed

• Read repository guidance, the current NPC implementation, authority helper, analogous RPC wrappers, and existing NPC test patterns.
• Inspected both supplied alternate and alternate-beta stripped Mono sources for the native RPC declaration and generated RPC seams.
• Read GitHub issue [BUG] NPC.Panic silently does nothing for non-host clients #245 and confirmed its reproduction, expected behavior, and reported runtime metadata.
• No repository files were modified, and no proprietary game artifacts were copied or redistributed.

Runtime validation remaining

• No build or xUnit command was run because this request was planning-only and local game-reference properties are not configured.
• The supplied Mono source does not prove IL2CPP wrapper shape or live FishNet behavior; verify the current Regular generated wrapper during implementation.
• Run the six-role/backend matrix: Mono host, remote client, dedicated server, and the same three roles on IL2CPP.
• Record human in-game evidence for server application, observer convergence, ownership acceptance, duplicate-effect absence, and no silent failure.

Diffuin run details

• Model: gpt-5.6-luna
• Reasoning: xhigh (source-backed issue plan)
• Elapsed: 370s
• Codex thread: 019fede1-f309-73f0-9ceb-97f0cc80e13b

---

AI notice: Generated with AI assistance and not guaranteed accurate. Verify findings and plans against the current source and runtime.

[ifBars]

@Diffuin Open a PR to close this issue

[diffuin]

I opened #255