fix: list the same stripped strings that text_duplicates counts - #794
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
duplicate_fraction is computed from hashes of stripped strings, so strings that differ only in surrounding whitespace count as duplicates. duplicates_dict was built from the raw strings, so a single call could report a non-zero duplicate fraction together with an empty duplicates_dict. Co-authored-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
duplicate_fractionhashes stripped strings, so"hello sun"and"hello sun "count as duplicates.duplicates_dictusedCounter(data)on the raw strings, so those pairs produced a non-zero fraction and an empty list.Count over the same stripped strings. Distinct from #499 (module_type only).
Test plan
{}vs{'hello sun': 2}) and passes afterpython -m pytest tests/test_metric_common.py -k text_duplicates→ 2 passed, 1 skipped