Skip to content

Guard Knowledge Workspace memory candidates as review proposals #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
Jul 3, 2026
Merged

Guard Knowledge Workspace memory candidates as review proposals #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/log.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,6 @@ logs.
- Preserved historical benchmark evidence rows that recorded the former singular
check command, and constrained docs task validation to allow only those exact
legacy evidence references.
- Added the XY-1153 Knowledge Workspace authority-boundary marker for changed-source
memory candidates so derived page deltas remain reviewable consolidation proposals
and cannot directly mutate Memory Authority or source evidence.
9 changes: 9 additions & 0 deletions docs/spec/system_knowledge_pages_v1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,15 @@ nested source refs.
- `allowed_variance`
- `previous_version_diff`

Knowledge delta memory candidates produced by changed-source watch/rebuild are
review proposals only. Their proposed payload and diff must carry
`elf.knowledge_delta.authority_boundary/v1` with
`authority = "derived_non_authoritative"`,
`review_surface = "consolidation_proposals"`,
`promotion_required_for_memory_authority = true`,
`direct_memory_ledger_mutation_allowed = false`, and
`source_mutation_allowed = false`.

`previous_version_diff` must use schema `elf.knowledge_page.version_diff/v1`.
Initial rebuilds must set `available = false` and explain that no previous version
exists. Later rebuilds must set `available = true` and include previous and new
Expand Down
8 changes: 8 additions & 0 deletions packages/elf-service/src/knowledge/tests_helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,14 @@ pub(super) fn assert_candidate_is_reviewable(candidate: &KnowledgeDeltaMemoryCan
assert_eq!(candidate.source_refs[0].kind.as_str(), "note");
assert_eq!(candidate.source_snapshot["source_mutation_allowed"], false);
assert_eq!(candidate.diff.after["reason"], "changed_claim");
assert_eq!(
candidate.diff.after["authority_boundary"]["review_surface"],
"consolidation_proposals"
);
assert_eq!(candidate.proposed_payload["type"], "plan");
assert_eq!(
candidate.proposed_payload["authority_boundary"]["authority"],
"derived_non_authoritative"
);
assert_eq!(candidate.proposed_payload["source_ref"]["schema"], "elf.knowledge_delta/v1");
}
13 changes: 13 additions & 0 deletions packages/elf-service/src/knowledge/tests_memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,20 @@ fn memory_candidate_uses_reviewable_consolidation_proposal_contract() {

assert_eq!(proposal.apply_intent, ConsolidationApplyIntent::CreateDerivedNote);
assert_eq!(proposal.source_refs.len(), 1);
assert_eq!(proposal.diff.after["authority_boundary"]["authority"], "derived_non_authoritative");
assert_eq!(
proposal.diff.after["authority_boundary"]["direct_memory_ledger_mutation_allowed"],
false
);
assert_eq!(proposal.proposed_payload["source_ref"]["source_mutation_allowed"], false);
assert_eq!(
proposal.proposed_payload["authority_boundary"]["review_surface"],
"consolidation_proposals"
);
assert_eq!(
proposal.proposed_payload["authority_boundary"]["promotion_required_for_memory_authority"],
true
);
assert_eq!(proposal.proposed_payload["source_ref"]["reason"], "changed_claim");
assert!(!proposal.markers.staleness.is_empty());
}
Expand Down
14 changes: 14 additions & 0 deletions packages/elf-service/src/knowledge/watch/candidates/proposal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ pub(in crate::knowledge::watch::candidates) fn candidate_diff(
"page_id": page.page.page_id,
"section_id": section.section_id,
"section_key": section.section_key,
"authority_boundary": knowledge_delta_authority_boundary(),
}),
}
}
Expand Down Expand Up @@ -77,6 +78,7 @@ pub(in crate::knowledge::watch::candidates) fn candidate_proposed_payload(
"scope": "project_shared",
"importance": 0.65,
"confidence": 0.72,
"authority_boundary": knowledge_delta_authority_boundary(),
"source_ref": {
"schema": "elf.knowledge_delta/v1",
"reason": reason,
Expand All @@ -89,6 +91,18 @@ pub(in crate::knowledge::watch::candidates) fn candidate_proposed_payload(
})
}

fn knowledge_delta_authority_boundary() -> Value {
serde_json::json!({
"schema": "elf.knowledge_delta.authority_boundary/v1",
"origin_layer": "knowledge_workspace",
"authority": "derived_non_authoritative",
"review_surface": "consolidation_proposals",
"promotion_required_for_memory_authority": true,
"direct_memory_ledger_mutation_allowed": false,
"source_mutation_allowed": false,
})
}

fn candidate_markers(candidate: &KnowledgeDeltaMemoryCandidate) -> ConsolidationMarkers {
let marker = ConsolidationMarker {
severity: ConsolidationMarkerSeverity::Medium,
Expand Down