Guard Knowledge Workspace memory candidates as review proposals#347
Merged
Conversation
…ory candidates as review proposals","authority":"XY-1153"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual intervention
no_effective_diff; the Decodex run also hit an app-server output timeout. The retained worktree was clean except Decodex metadata, so I manually implemented the smallest aligned slice in the Decodex worktree.packages/elf-service/src/knowledge/watch/candidates/proposal.rs,packages/elf-service/src/knowledge/tests_memory.rs,packages/elf-service/src/knowledge/tests_helpers.rs,docs/spec/system_knowledge_pages_v1.md,docs/log.md.cargo make fmt-check; targetedcargo test -p elf-service knowledge::tests::tests_memory::memory_candidate_uses_reviewable_consolidation_proposal_contract;python3 scripts/check-docs.py;git diff --check; fullcargo make checks.Validation
cargo make checks