Skip to content

fix(migrator): drop duplicate PRIMARY KEY clause in AlterColumn #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
libvoid wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −1
Open

fix(migrator): drop duplicate PRIMARY KEY clause in AlterColumn #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion migrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,18 @@ func (m Migrator) AlterColumn(value interface{}, name string) error {
for i, f := range ddl.fields {
if matches := columnRegexp.FindStringSubmatch(f); len(matches) > 1 && matches[1] == field.DBName {
ddl.fields[i] = fmt.Sprintf("`%v` ?", field.DBName)
sqlArgs = []interface{}{m.FullDataTypeOf(field)}
dataType := m.FullDataTypeOf(field)
sqlArgs = []interface{}{dataType}
if strings.Contains(strings.ToUpper(dataType.SQL), "PRIMARY KEY") {
for j, g := range ddl.fields {
if strings.HasPrefix(strings.ToUpper(g), "PRIMARY KEY") {
if cols, err := parseAllColumns(g); err == nil && len(cols) == 1 && cols[0] == field.DBName {
ddl.fields = append(ddl.fields[:j], ddl.fields[j+1:]...)
break
}
}
}
}
// table created by old version might look like `CREATE TABLE ? (? varchar(10) UNIQUE)`.
// FullDataTypeOf doesn't contain UNIQUE, so we need to add unique constraint.
if strings.Contains(strings.ToUpper(matches[3]), " UNIQUE") {
Expand Down
Loading