fix(migrator): drop duplicate PRIMARY KEY clause in AlterColumn - #249
Open
libvoid wants to merge 1 commit into
Open
fix(migrator): drop duplicate PRIMARY KEY clause in AlterColumn#249libvoid wants to merge 1 commit into
libvoid wants to merge 1 commit into
Conversation
AlterColumn rewrites a column's definition using FullDataTypeOf, which inlines "PRIMARY KEY AUTOINCREMENT" for autoincrement fields. If the table's DDL already declared that column's primary key as a separate "PRIMARY KEY (`col`)" table constraint, that clause was never removed producing a CREATE TABLE with two primary key definitions and failing with "table ... has more than one primary key". We need to look for a matching standalone PRIMARY KEY clause referencing that column alone and drop it. Composite primary keys are left untouched, since they parse to more than one column. This commit fixes a regression introduced since 139bd30 (v1.5.4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
AlterColumn rewrites a column's definition using FullDataTypeOf, which inlines
PRIMARY KEY AUTOINCREMENTfor autoincrement fields.If the table's DDL already declared that column's primary key as a separate
PRIMARY KEY (`col`)table constraint, that clause was never removed producing a CREATE TABLE with two primary key definitions and failing with "table ... has more than one primary key".We need to look for a matching standalone PRIMARY KEY clause referencing that column alone and drop it. Composite primary keys are left untouched, since they parse to more than one column.
This commit fixes a regression introduced since 139bd30 (v1.5.4)
User Case Description
I hit this bug in our project when trying to update the DB schema.
Here is a MCVE: