Skip to content

Fix SobolEngine.fast_forward with n=0 (#5262) #5262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saitcakmak wants to merge 1 commit into from
+3 −2
Closed

Fix SobolEngine.fast_forward with n=0 (#5262) #5262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ax/analysis/plotly/tests/test_sensitivity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

# pyre-strict

from itertools import product
from unittest.mock import patch

from ax.adapter.registry import Generators
Expand Down
4 changes: 3 additions & 1 deletion ax/generators/random/sobol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ def init_engine(self, n_tunable_features: int) -> SobolEngine:
if not self._engine:
self._engine = SobolEngine(
dimension=n_tunable_features, scramble=self.scramble, seed=self.seed
).fast_forward(self.init_position)
)
if self.init_position > 0:
self._engine.fast_forward(self.init_position)
return self._engine

@property
Expand Down
Loading