Fix SobolEngine.fast_forward with n=0 (#5262) - #5262
Closed
saitcakmak wants to merge 1 commit into
Closed
Conversation
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113989171. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Jul 29, 2026
Summary: A recent torch change made it so that n=0 is not a valid input to SobolEngine.fast_forward. This diff should fix the resulting failures (in internal CI). ___ Differential Revision: D113989171
Summary: A recent torch change made it so that n=0 is not a valid input to SobolEngine.fast_forward. This diff should fix the resulting failures (in internal CI). ___ Differential Revision: D113989171
saitcakmak
force-pushed
the
export-D113989171
branch
from
July 29, 2026 01:19
12f8571 to
59f686b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5262 +/- ##
=======================================
Coverage 96.58% 96.59%
=======================================
Files 621 621
Lines 70744 70745 +1
=======================================
+ Hits 68329 68335 +6
+ Misses 2415 2410 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 00b03db. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A recent torch change made it so that n=0 is not a valid input to SobolEngine.fast_forward. This diff should fix the resulting failures (in internal CI).
Differential Revision: D113989171