Skip to content

Fix SobolEngine.fast_forward with n=0 (#5262) - #5262

Closed
saitcakmak wants to merge 1 commit into
facebook:mainfrom
saitcakmak:export-D113989171
Closed

Fix SobolEngine.fast_forward with n=0 (#5262)#5262
saitcakmak wants to merge 1 commit into
facebook:mainfrom
saitcakmak:export-D113989171

Conversation

@saitcakmak

@saitcakmak saitcakmak commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary:

A recent torch change made it so that n=0 is not a valid input to SobolEngine.fast_forward. This diff should fix the resulting failures (in internal CI).


Differential Revision: D113989171

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 29, 2026
@meta-codesync

meta-codesync Bot commented Jul 29, 2026

Copy link
Copy Markdown

@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113989171.

saitcakmak added a commit to saitcakmak/Ax that referenced this pull request Jul 29, 2026
Summary:

A recent torch change made it so that n=0 is not a valid input to SobolEngine.fast_forward. This diff should fix the resulting failures (in internal CI).

___

Differential Revision: D113989171
Summary:

A recent torch change made it so that n=0 is not a valid input to SobolEngine.fast_forward. This diff should fix the resulting failures (in internal CI).

___

Differential Revision: D113989171
@meta-codesync meta-codesync Bot changed the title Fix SobolEngine.fast_forward with n=0 Fix SobolEngine.fast_forward with n=0 (#5262) Jul 29, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (7abf5d6) to head (59f686b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5262   +/-   ##
=======================================
  Coverage   96.58%   96.59%           
=======================================
  Files         621      621           
  Lines       70744    70745    +1     
=======================================
+ Hits        68329    68335    +6     
+ Misses       2415     2410    -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meta-codesync meta-codesync Bot closed this in 00b03db Jul 29, 2026
@meta-codesync meta-codesync Bot added the Merged label Jul 29, 2026
@meta-codesync

meta-codesync Bot commented Jul 29, 2026

Copy link
Copy Markdown

This pull request has been merged in 00b03db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants