Skip to content

fix(template): Harmonia perspective icons use the Lucide name, not a unicons URL #6264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delchev merged 1 commit into from
Jul 11, 2026
Merged

fix(template): Harmonia perspective icons use the Lucide name, not a unicons URL #6264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions components/template/template-application-ui-harmonia-java/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,17 @@ Velocity model vars (per-entity collections, same as the Angular module):
`${primaryKeysString}`, `$hasProcess`. The aggregate `index.html` is generated with
no `collection`, so `$models` = `model.entities`.

**Perspective icons are Lucide NAMES, not unicons URLs.** The generated `perspective.js`
(both the shared-shell `perspective/perspective.js.template` and the My-shell
`my/my-perspective.js.template`) emits `icon: '${iconName}'` — the bare Lucide / Harmonia
built-in icon name (the model's `iconName`), which the application shell and My shell render
via `x-h-lucide`. It does **NOT** emit `${perspectiveIcon}` (the `/services/web/resources/unicons/<name>.svg`
URL): that path is only meaningful to the legacy **AngularJS** perspective and 404s in the Harmonia
shells (whose `isSvgIcon`/`isImageIcon` would send a `.svg` path down the `<svg data-link>` branch to
a missing file). The `.model` still carries `perspectiveIcon` for the AngularJS stack — untouched.
So the intent `icon:` must be a valid Lucide name (bundled `org.webjars.npm:lucide` `dist/esm/icons/<name>.js`,
currently 1.8.0); an unknown name renders blank.

## Parity checklist (TODO)

| View type | Angular collection | Status |
Expand Down
4 changes: 3 additions & 1 deletion ...META-INF/dirigible/template-application-ui-harmonia-java/ui/my/my-perspective.js.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ const perspectiveData = {
#if($perspectiveOrder)
order: ${perspectiveOrder},
#end
icon: '${perspectiveIcon}'
// Lucide / Harmonia built-in icon NAME (rendered by the shell via x-h-lucide), not a unicons SVG
// URL - the Harmonia shells resolve a bare name through Lucide; a '<name>.svg' path would 404.
icon: '${iconName}'
};
if (typeof exports !== 'undefined') {
exports.getPerspective = () => perspectiveData;
Expand Down
4 changes: 3 additions & 1 deletion ...NF/dirigible/template-application-ui-harmonia-java/ui/perspective/perspective.js.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ const perspectiveData = {
#if($perspectiveOrder)
order: ${perspectiveOrder},
#end
icon: '${perspectiveIcon}'
// Lucide / Harmonia built-in icon NAME (rendered by the shell via x-h-lucide), not a unicons SVG
// URL - the Harmonia shells resolve a bare name through Lucide; a '<name>.svg' path would 404.
icon: '${iconName}'
};
if (typeof exports !== 'undefined') {
exports.getPerspective = () => perspectiveData;
Expand Down
Loading