fix(template): Harmonia perspective icons use the Lucide name, not a unicons URL#6264
Merged
Merged
Conversation
…unicons URL
The generated perspective.js (shared application shell + My shell) emitted
icon: '${perspectiveIcon}', a /services/web/resources/unicons/<name>.svg URL. But
the Harmonia shells render a perspective icon via x-h-lucide from a bare icon NAME;
an '<name>.svg' path is treated as an SVG link and 404s (the unicons pack does not
contain the Lucide-named icons the intent uses - palmtree, gauge, calendar-check, ...).
Emit icon: '${iconName}' instead - the model's bare Lucide/Harmonia built-in name,
which the shells resolve through Lucide. The .model still carries perspectiveIcon for
the legacy AngularJS stack, which is left untouched (Harmonia templates only).
So an intent icon: must now be a valid Lucide name (bundled org.webjars.npm:lucide,
currently 1.8.0). Documented in the module README.
Verified on a running instance: the My shell and the Harmonia application shell no
longer request any /services/web/resources/unicons/*.svg (previously 404) - the
perspective icons render via Lucide.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every generated Harmonia app's perspective 404'd its sidebar icon in the shared application shell and the My shell:
Cause
The generated
perspective.js(bothperspective/perspective.js.templateandmy/my-perspective.js.template) emittedicon: '${perspectiveIcon}'— a/services/web/resources/unicons/<name>.svgURL. But the Harmonia shells render a perspective icon viax-h-lucidefrom a bare icon NAME; an.svgpath is sent down the<svg data-link>branch and points at a unicons file that does not exist (the intenticon:values —palmtree,gauge,calendar-check, … — are Lucide names, and the unicons pack uses entirely different names).Fix
Emit
icon: '${iconName}'— the model's bare Lucide/Harmonia built-in icon name — which the shells resolve through Lucide. Harmonia templates only: the.modelstill carriesperspectiveIcon(the unicons URL) for the legacy AngularJS stack, which is untouched.Consequence, now documented in the module README: an intent
icon:must be a valid Lucide name (bundledorg.webjars.npm:lucide, currently 1.8.0). An unknown name renders a blank icon.Verification
Driven on a running instance (Chrome, form-login) after applying the equivalent change to the served perspective files:
#/app/kf-mod-vacations-my-VacationRequest/my/VacationRequest→ zero console errors (previously twounicons/*.svg404s)./services/web/application/→ nounicons/*.svgrequests at all (icons render via Lucide).Downstream: the KeyFolders module intents were swept for invalid Lucide names alongside this (
palmtree→tree-palm,alert-triangle→triangle-alert,id-badge→id-card,user-clock→clock).🤖 Generated with Claude Code