Add planning group world queries#2695
Draft
TomCC7 wants to merge 4 commits into
Draft
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
TomCC7
commented
Jul 2, 2026
Comment on lines
+83
to
+84
| new_groups = PlanningGroupRegistry() | ||
| new_groups.add_robot(config) |
Member
Author
There was a problem hiding this comment.
what is this for if we have self._planning_groups?
| positions.append(float(pos_by_name[local_name])) | ||
| return JointState({"name": names, "position": positions}) | ||
|
|
||
| def get_current_group_joint_state( |
Member
Author
There was a problem hiding this comment.
naming should be coherent with current_global_joint_state
| } | ||
| ) | ||
|
|
||
| def _joint_state_for_group_query( |
Member
Author
There was a problem hiding this comment.
shouldn't this be a util function in groups folder?
|
|
||
| # Tracking data | ||
| self._robots: dict[WorldRobotID, _RobotData] = {} | ||
| self._planning_groups = PlanningGroupRegistry() |
Member
Author
There was a problem hiding this comment.
we should have only one single planning group registry across the program
| logger.warning("RoboPlanWorld does not currently provide manipulation visualization") | ||
|
|
||
| self._robots: dict[WorldRobotID, _RoboPlanRobotData] = {} | ||
| self._planning_groups = PlanningGroupRegistry() |
Member
Author
There was a problem hiding this comment.
same here, planning group registy should stay in world monitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Planning-group definitions exist, but world backends and monitors still answered FK, Jacobian, and state queries through robot-scoped APIs. Callers needed to infer tip frames and local/global joint mappings instead of querying a selected planning group directly.
Closes: N/A
Solution
WorldSpecand implement them for Drake and RoboPlan.How to Test
openspec validate planning-world-monitor-groups --type change --strict --no-interactiveuv run pytest dimos/manipulation/planning/world/test_drake_world_planning_groups.py dimos/manipulation/test_roboplan_world.py dimos/manipulation/planning/monitor/test_world_monitor.py -qpydrakeis not installed.uv run --group lint mypy dimos/manipulation/planning/spec/protocols.py dimos/manipulation/planning/world/drake_world.py dimos/manipulation/planning/world/roboplan_world.py dimos/manipulation/planning/monitor/world_monitor.pyContributor License Agreement