fix: register map/replay clouds via frame_id + TF tree#2690
Draft
jeff-hykin wants to merge 7 commits into
Draft
Conversation
…ved, in-cloud ts aligned to recording time
Drive PointCloud/Odometry world-registration off each message's frame_id instead of a baked-in per-observation pose. World-frame messages render directly; non-world frames are looked up in the recording's `tf` stream via a read-only DbTf (no loop closure) and skipped with a warning if unplaceable. DbTf uses an unbounded time tolerance so once-published static transforms (mounts, world<-map) latch across the whole recording, while densely sampled dynamic transforms still resolve to their nearest sample.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…er loop) Regenerated pointlio_lidar + pointlio_odometry via pcap_to_db --rate 2.0 on china_office.pcap, timestamps re-anchored to the recording epoch and tf tree rebuilt (static mounts + odom->base_link). Reproduces the known-good __rate2 trajectory; 2x packs denser scans per Point-LIO wall-clock accumulation window than 1x, yielding a tighter loop closure.
Recordings can reference Python classes not present in the current checkout. summary/replay now warn and skip those streams instead of crashing; requesting an unresolvable stream by name still raises.
Remove the 4 ground-truth pointlio streams (all worse than the 1.5x replay), copy the six surf*/map* config runs' odometry from the grid sweep, and align every pointlio_odometry* stream (including the __rate* variants) to the canonical recording anchor so they overlay the tf tree and lidar.
pointlio_odometry, tf, and pointlio_lidar are pulled from the 1x regen (unfrozen odom, correctly-recorded 5-edge tf tree) and shifted onto the June-12 data clock so they align with the kept color_image / gtsam_odom / raw_april_tags streams. Intermediate checkpoint before PGO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vibed extraction of some of my existing map/db changes. Will check soon.