Include unitree-dds in tests#2647
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2647 +/- ##
==========================================
- Coverage 71.10% 70.75% -0.35%
==========================================
Files 897 897
Lines 80290 80290
Branches 7183 7183
==========================================
- Hits 57089 56810 -279
- Misses 21319 21624 +305
+ Partials 1882 1856 -26
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Greptile SummaryThis PR removes a previous workaround that excluded
Confidence Score: 5/5Safe to merge — the change installs a well-known system library and re-enables a previously disabled dependency group, with no logic changes. The three-file change is tightly scoped: add one apt package to the Docker image, expand one extras list in pyproject.toml, and let uv regenerate the lockfile. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Self-Hosted CI Runner] --> B[docker/python/Dockerfile]
B --> C[apt-get install libcyclonedds-dev]
C --> D{CycloneDDS C lib available?}
D -->|Yes - after this PR| E[uv install dimos with unitree-dds extra]
D -->|No - before this PR| F[uv install dimos with unitree extra plus mcap directly]
E --> G[cyclonedds Python wheel links against system lib]
E --> H[unitree-sdk2py-dimos installed]
E --> I[mcap pulled in transitively]
F --> J[Tests run without full DDS support]
G --> K[Full unitree-dds test suite runs]
H --> K
I --> K
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Self-Hosted CI Runner] --> B[docker/python/Dockerfile]
B --> C[apt-get install libcyclonedds-dev]
C --> D{CycloneDDS C lib available?}
D -->|Yes - after this PR| E[uv install dimos with unitree-dds extra]
D -->|No - before this PR| F[uv install dimos with unitree extra plus mcap directly]
E --> G[cyclonedds Python wheel links against system lib]
E --> H[unitree-sdk2py-dimos installed]
E --> I[mcap pulled in transitively]
F --> J[Tests run without full DDS support]
G --> K[Full unitree-dds test suite runs]
H --> K
I --> K
Reviews (1): Last reviewed commit: "Include unitree-dds in tests" | Re-trigger Greptile |
No description provided.