fix(i18n): use a correct plural key for provider-grid's more-providers label - #5477
Merged
Conversation
…s label
The English-only {plural} interpolation appended a hardcoded "s" suffix,
producing the non-word "provedors" in Portuguese (and dropping adjective
agreement: "adicional" instead of "adicionais"). Split into explicit
singular/plural keys per locale instead.
decocms Bot
pushed a commit
that referenced
this pull request
Jul 31, 2026
PR: #5477 fix(i18n): use a correct plural key for provider-grid's more-providers label Bump type: patch - decocms (apps/api/package.json): 4.150.22 -> 4.150.23 - @decocms/native (apps/native/package.json): 4.150.22 -> 4.150.23 Deploy-Scope: web
pedrofrxncx
added a commit
that referenced
this pull request
Jul 31, 2026
…eys (#5479) The single "{count} secret{plural} stored" template only appends an English "s" to the count word, so pt-br's "{count} segredo{plural} armazenado" never pluralizes "armazenado" (should be "armazenados") when count > 1 — same bug class just fixed in provider-grid.tsx (#5477). Split into secretsCountSingular/secretsCountPlural per-locale keys instead.
pedrofrxncx
added a commit
that referenced
this pull request
Jul 31, 2026
…5487) The English-only {plural} interpolation appended a hardcoded "s" suffix to "connection", producing the non-word "conexãos" in pt-br (should be "conexões") — the same bug class just fixed in provider-grid.tsx (#5477) and secrets.tsx (#5479). Split deleteButton/deleteDescription/deleteTitle into explicit Singular/Plural keys per locale instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the recent i18n refactor hardening pass in
apps/web/src/i18n— found while auditing task-board/library/settings dictionaries for count-based interpolation bugs (assignee-picker and org-connect are already covered by open PRs #5170 / #5382, so this fix targets a different file).The bug:
settings.aiProviders.moreProvidersused a single{plural}placeholder filled in JS with a hardcoded English suffix —plural: hiddenCount === 1 ? "" : "s". For the pt-br dictionary entry"{count} provedor{plural} adicional", passing"s"renders "provedors" — not a real Portuguese word — and also leaves the adjective "adicional" un-pluralized (should be "adicionais"). A Portuguese-speaking user with more than one hidden AI provider sees broken grammar in Settings → AI Providers.The fix: replaced the single interpolated key with explicit
moreProvidersSingular/moreProvidersPluralkeys (mirroring the pattern already used elsewhere, e.g.content-browser.tsx's singular/plural ternaries), so each locale's dictionary owns its own correct singular and plural wording instead of assuming an English "append s" rule. pt-br now reads "{count} provedores adicionais" for the plural case.To confirm: open Settings → AI Providers with more than one hidden/collapsed provider tile while the org language is set to Portuguese (Brazil) — the "show more" row should read "N provedores adicionais", not "N provedors adicional".
Checks run locally:
bun run fmt(clean),bunx tsc --noEmitinapps/web(passes — the pt-br dictionary'ssatisfies Record<keyof typeof settingsEn, string>constraint also catches any key-parity drift at compile time). Full CI runs the broader suite.Summary by cubic
Fixes pluralization for the "more providers" label in Settings → AI Providers by replacing a hardcoded English suffix with proper singular/plural i18n keys. Portuguese (Brazil) now shows correct grammar.
settings.aiProviders.moreProvidersSingularandsettings.aiProviders.moreProvidersPluraltoenandpt-brdictionaries.hiddenCountand pass{count}only.Written for commit 8e6ad36. Summary will update on new commits.