fix(orgs): use singular/plural i18n keys in the bulk-delete dialog - #5487
Merged
Conversation
The English-only {plural} interpolation appended a hardcoded "s" suffix to
"connection", producing the non-word "conexãos" in pt-br (should be
"conexões") — the same bug class just fixed in provider-grid.tsx (#5477)
and secrets.tsx (#5479). Split deleteButton/deleteDescription/deleteTitle
into explicit Singular/Plural keys per locale instead.
pedrofrxncx
enabled auto-merge (squash)
July 31, 2026 03:45
decocms Bot
pushed a commit
that referenced
this pull request
Jul 31, 2026
PR: #5487 fix(orgs): use singular/plural i18n keys in the bulk-delete dialog Bump type: patch - decocms (apps/api/package.json): 4.150.27 -> 4.150.28 - @decocms/native (apps/native/package.json): 4.150.27 -> 4.150.28 Deploy-Scope: web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tick's two merges (settings env-alias fallback #5483, chat latency prop removal #5482) turned out fully clean on re-inspection —
resolve-config.ts's alias pairs all now use the saferesolveAliasedEnvhelper, andcommon.tsx/generic.tsxhave no leftover deadlatencyreferences. Widening the hunt to the same i18n plural-interpolation bug class fixed twice very recently in this area (#5477 provider-grid.tsx, #5479 secrets.tsx) turned up one more live instance.orgs.bulkDeleteDialog.deleteButton/deleteDescription/deleteTitlebuild their pt-br strings as"conexão{plural}", where the caller (bulk-delete-dialog.tsx) always passes a hardcoded Englishplural: count !== 1 ? "s" : "". For count > 1 this renders "conexãos" instead of the correct pt-br plural "conexões" — an actual, visible grammar bug for any pt-br user bulk-deleting more than one connection.Fix: replaced the three
{plural}-templated keys with explicitSingular/Pluralkey pairs per locale (matching the pattern used in the #5479 fix), and updated the caller to select the key based oncount === 1instead of interpolating a suffix.Failure scenario: a pt-br user selects 2+ connections and opens the bulk-delete dialog — before this fix, the dialog title/button/description read "Excluir 2 conexãos" (not a word) instead of "Excluir 2 conexões".
Reviewer check:
cd apps/web && bunx tsc --noEmit(passes —pt-br/orgs.tssatisfiesRecord<keyof typeof en, string>, so a missing key would be a compile error), and manually open the org connections list, select 2+ connections, and trigger bulk delete withlanguageset to pt-br.Locally ran:
bun run fmt,cd apps/web && bunx tsc --noEmit,bunx oxlinton the three changed files (all clean). No dedicated test exists for this component's i18n and none of the other required checks apply (no test file for this component); full CI covers the rest.Summary by cubic
Fixes pluralization in the org connections bulk-delete dialog by replacing suffix interpolation with singular/plural i18n keys. This corrects pt-br text (e.g., “conexões”) and avoids similar plural errors.
...Singular/...Pluralkeys for delete button, title, and description inen/orgs.tsandpt-br/orgs.ts.orgs/bulk-delete-dialog.tsxto select keys based oncount === 1and pass{ count }only."s"suffix to produce correct pt-br grammar for counts > 1.Written for commit 022f018. Summary will update on new commits.