Make the Tengwar gap rule actually apply#538
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of the unmoving gap, with apology owed: the three spacing PRs (#534, #535, #537) were visual no-ops. The margin lived on a single-class selector, .entry-teng, and the explorer's generic .entry-body p rule outweighs it, so the paragraph kept its stock .25rem margin the whole time and every merged nudge was silently discarded. The gap the maintainer has been looking at never changed once.
This PR makes the rule real and lands the end state the instruction sequence pointed at:
Measured in headless Chrome against the built stylesheet with the real kaeli entry markup: the gap between the IPA line's bottom and the rendering's top goes from 32.6px to 3.1px at the site's root font size, a hairline. The bottom margin (0.8rem before the description) also takes effect now for the same reason.
The single tunable remains the -0.85rem top margin. The measurement harness was a throwaway probe page in the session scratchpad; no server was started and nothing was added to the repository beyond this stylesheet change.