Balance the space above and below the entry's Tengwar hand#539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Balances the opened entry's Tengwar line per the maintainer's review of the deployed hairline: the space above it now matches the space below it.
Measured in the headless-Chrome probe against the built stylesheet: the below-gap (the line's 0.8rem bottom margin collapsed with the description's stock top margin) is 16.6px at the site's root font size, and the top margin moves from -0.85rem to -0.2rem to land the above-gap at the same 16.6px. Verified before shipping: 16.64px above, 16.63px below, with a screenshot confirming the even seat.
The top margin remains the single tunable, and since #538 it demonstrably works.