-
Notifications
You must be signed in to change notification settings - Fork 2
Fix codex-termux manifest synchronization #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,80 @@ | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const repoRoot = path.resolve(__dirname, '..'); | ||
| const manifestPath = path.join(repoRoot, 'config', 'codex-termux-release-manifest.json'); | ||
| /** | ||
| * Update both root and package manifests with candidate version and state. | ||
| * Ensures updated_at timestamp is identical in both files. | ||
| * | ||
| * @param {Object} opts | ||
| * @param {string} opts.rootPath - path to root manifest | ||
| * @param {string} opts.packagePath - path to package manifest | ||
| * @param {string} opts.candidateVersion - new latest_candidate_version | ||
| * @param {string} opts.candidateState - new candidate_state_status | ||
| */ | ||
| function updateManifests({ | ||
| rootPath, | ||
| packagePath, | ||
| candidateVersion, | ||
| candidateState, | ||
| }) { | ||
| if (!rootPath || !packagePath || !candidateVersion || !candidateState) { | ||
| throw new Error('All parameters (rootPath, packagePath, candidateVersion, candidateState) are required'); | ||
| } | ||
|
|
||
| function usage() { | ||
| console.error('usage: node scripts/update-codex-candidate-manifest.js <candidate-version> <candidate-state>'); | ||
| process.exit(2); | ||
| } | ||
| // Generate timestamp once, use for both files | ||
| const updatedAt = new Date().toISOString(); | ||
|
|
||
| const candidateVersion = process.argv[2]; | ||
| const candidateState = process.argv[3]; | ||
| // Update root manifest | ||
| const rootManifest = JSON.parse(fs.readFileSync(rootPath, 'utf8')); | ||
| rootManifest.latest_candidate_version = candidateVersion; | ||
| rootManifest.candidate_state_status = candidateState; | ||
| rootManifest.updated_at = updatedAt; | ||
| fs.writeFileSync(rootPath, `${JSON.stringify(rootManifest, null, 2)}\n`); | ||
|
|
||
| if (!candidateVersion || !candidateState) { | ||
| usage(); | ||
| // Update package manifest | ||
| // Read existing package manifest to preserve distribution-specific fields | ||
| const packageManifest = JSON.parse(fs.readFileSync(packagePath, 'utf8')); | ||
| packageManifest.latest_candidate_version = candidateVersion; | ||
| packageManifest.candidate_state_status = candidateState; | ||
| packageManifest.updated_at = updatedAt; | ||
| fs.writeFileSync(packagePath, `${JSON.stringify(packageManifest, null, 2)}\n`); | ||
| } | ||
|
|
||
| const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf8')); | ||
| manifest.latest_candidate_version = candidateVersion; | ||
| manifest.candidate_state_status = candidateState; | ||
| manifest.updated_at = new Date().toISOString(); | ||
| // CLI interface | ||
| if (require.main === module) { | ||
| const repoRoot = path.resolve(__dirname, '..'); | ||
| const rootManifestPath = path.join(repoRoot, 'config', 'codex-termux-release-manifest.json'); | ||
| const packageManifestPath = path.join( | ||
| repoRoot, | ||
| 'packages', | ||
| 'codex-termux', | ||
| 'config', | ||
| 'codex-termux-release-manifest.json' | ||
| ); | ||
|
|
||
| function usage() { | ||
| console.error('usage: node scripts/update-codex-candidate-manifest.js <candidate-version> <candidate-state>'); | ||
| process.exit(2); | ||
| } | ||
|
|
||
| const candidateVersion = process.argv[2]; | ||
| const candidateState = process.argv[3]; | ||
|
|
||
| fs.writeFileSync(manifestPath, `${JSON.stringify(manifest, null, 2)}\n`); | ||
| if (!candidateVersion || !candidateState) { | ||
| usage(); | ||
| } | ||
|
|
||
| try { | ||
| updateManifests({ | ||
| rootPath: rootManifestPath, | ||
| packagePath: packageManifestPath, | ||
| candidateVersion, | ||
| candidateState, | ||
| }); | ||
| } catch (err) { | ||
| console.error('Error updating manifests:', err.message); | ||
| process.exit(1); | ||
| } | ||
| } | ||
|
|
||
| module.exports = { updateManifests }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the next candidate is ingested after this release finalizes,
scripts/finalize-update-docs.shonly advanceslatest_audited_versionand leavesprevious_stable_versionat the prior value; this function then starts the new candidate without derivingprevious_stable_versionfrom the current audited/latest version. The new guard in.github/workflows/promote-and-publish.ymlcompares that stale field to npmlatest, so promoting the following release (for example 0.144.6 after 0.144.5 is latest) will fail until the manifest is manually edited. Please updateprevious_stable_versionfor both manifests when starting a new candidate, or move that maintenance into finalization.Useful? React with 👍 / 👎.