Fix codex-termux manifest synchronization - #127
Conversation
…nfigs - Update 0.144.5 manifest data: previous_stable_version to 0.144.4 (matches current npm latest) - Update package manifest: latest_candidate_version to 0.144.5 - Refactor update-codex-candidate-manifest.js to export updateManifests function for testability - Ensure updated_at timestamp is identical in both root and package manifests (single Date generation) - Add comprehensive tests for manifest synchronization (7 test cases) - Update codex-version-watch.yml to include package manifest in git add - Add verification guard in promote-and-publish.yml to validate previous_stable_version matches npm registry latest before promotion
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8f6ef5285
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rootManifest.latest_candidate_version = candidateVersion; | ||
| rootManifest.candidate_state_status = candidateState; | ||
| rootManifest.updated_at = updatedAt; |
There was a problem hiding this comment.
When the next candidate is ingested after this release finalizes, scripts/finalize-update-docs.sh only advances latest_audited_version and leaves previous_stable_version at the prior value; this function then starts the new candidate without deriving previous_stable_version from the current audited/latest version. The new guard in .github/workflows/promote-and-publish.yml compares that stale field to npm latest, so promoting the following release (for example 0.144.6 after 0.144.5 is latest) will fail until the manifest is manually edited. Please update previous_stable_version for both manifests when starting a new candidate, or move that maintenance into finalization.
Useful? React with 👍 / 👎.
1 participant
Fix codex-termux manifest synchronization between root and package configs
Summary
Changes