[release-0.16] Fix rclone mover crash on PVCs with symlinks - #2085
Merged
openshift-merge-bot[bot] merged 3 commits intoAug 5, 2026
Conversation
Exclude symlinks from the getfacl pipeline in active.sh. On UBI9's acl-2.4.0, getfacl -P returns ELOOP on symlinks, killing the script under pipefail before rclone sync runs. Symlinks have no meaningful ACLs so skipping them loses no data. Adds e2e test with dangling and relative symlinks on the source PVC. Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
|
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: falconizmi, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-0.16 #2085 +/- ##
==============================================
- Coverage 68.7% 68.6% -0.1%
==============================================
Files 58 58
Lines 6056 6056
==============================================
- Hits 4164 4158 -6
- Misses 1581 1584 +3
- Partials 311 314 +3 🚀 New features to boost your workflow:
|
openshift-merge-bot
Bot
merged commit Aug 5, 2026
2d7df53
into
backube:release-0.16
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2082
/assign falconizmi