Fix rclone mover crash on PVCs with symlinks - #2082
Conversation
Exclude symlinks from the getfacl pipeline in active.sh. On UBI9's acl-2.4.0, getfacl -P returns ELOOP on symlinks, killing the script under pipefail before rclone sync runs. Symlinks have no meaningful ACLs so skipping them loses no data. Adds e2e test with dangling and relative symlinks on the source PVC. Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: falconizmi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
|
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/retest There was an issue with the aws account maxing out s3 storage - I've done some cleanup which should hopefully help |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
=====================================
Coverage 68.6% 68.7%
=====================================
Files 58 58
Lines 6056 6056
=====================================
+ Hits 4158 4164 +6
+ Misses 1584 1581 -3
+ Partials 314 311 -3 🚀 New features to boost your workflow:
|
|
/cherry-pick release-0.16 |
|
@falconizmi: new pull request created: #2085 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |



Summary
acl-2.4.0,getfacl -Preturns ELOOP on symlinks, killing the script underpipefail.find | getfaclpipeline. Symlinks have no meaningful ACLs.Notes
release-0.16andrelease-0.15after merge.