Skip to content

Fix rclone mover crash on PVCs with symlinks - #2082

Merged
openshift-merge-bot[bot] merged 3 commits into
backube:mainfrom
falconizmi:fix/rclone-symlink-eloop
Aug 5, 2026
Merged

Fix rclone mover crash on PVCs with symlinks#2082
openshift-merge-bot[bot] merged 3 commits into
backube:mainfrom
falconizmi:fix/rclone-symlink-eloop

Conversation

@falconizmi

Copy link
Copy Markdown
Contributor

Summary

  • Rclone mover crashes when source PVC contains symlinks. On UBI9's acl-2.4.0, getfacl -P returns ELOOP on symlinks, killing the script under pipefail.
  • Fix: exclude symlinks from the find | getfacl pipeline. Symlinks have no meaningful ACLs.
  • Adds e2e test with dangling and relative symlinks on the source PVC.

Notes

  • Bug exists since v0.15.0. Cherry-pick to release-0.16 and release-0.15 after merge.

Exclude symlinks from the getfacl pipeline in active.sh. On UBI9's
acl-2.4.0, getfacl -P returns ELOOP on symlinks, killing the script
under pipefail before rclone sync runs. Symlinks have no meaningful
ACLs so skipping them loses no data.

Adds e2e test with dangling and relative symlinks on the source PVC.

Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
@openshift-ci

openshift-ci Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: falconizmi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
@falconizmi

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@falconizmi

Copy link
Copy Markdown
Contributor Author

/retest

Signed-off-by: Ismail Ibrahim Quwarah <iquwarah@redhat.com>
@openshift-ci openshift-ci Bot added size/M and removed size/L labels Aug 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@tesshuflower

Copy link
Copy Markdown
Contributor

/lgtm

@falconizmi

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@falconizmi

Copy link
Copy Markdown
Contributor Author

/retest

@tesshuflower

tesshuflower commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

/retest

There was an issue with the aws account maxing out s3 storage - I've done some cleanup which should hopefully help

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.7%. Comparing base (44ebe86) to head (a60c034).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2082   +/-   ##
=====================================
  Coverage   68.6%   68.7%           
=====================================
  Files         58      58           
  Lines       6056    6056           
=====================================
+ Hits        4158    4164    +6     
+ Misses      1584    1581    -3     
+ Partials     314     311    -3     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot
openshift-merge-bot Bot merged commit fcd1203 into backube:main Aug 5, 2026
38 checks passed
@falconizmi

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-0.16

@openshift-cherrypick-robot

Copy link
Copy Markdown

@falconizmi: new pull request created: #2085

Details

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants