Skip to content

Add context to activationKey #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nanditaashok-ms wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add context to activationKey #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions connection-coordinator/schemas/environment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,15 @@ ActivationKey:
Required. User supplied account id/number on the destination CSP.
Receiving service MUST verify that the activation key was provided from an authorized user of this account.
type: string
context:

@bpescato-amazon bpescato-amazon May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I would like for us to establish a maximum size here -- being uniform with these numbers will prevent issues in the future.

@nanditaashok-ms As far as you know, would a limit of 500 characters INSIDE the context be reasonable (not counting the "context" key itself)
?

@nanditaashok-ms nanditaashok-ms May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 500 character limit should be large enough for the content inside of "context"

description: |-
Optional. Arbitrary key-value pairs set by the key creator. This can be used to pass additional context or metadata.
Providers MAY enforce a maximum character or size limit for this field.
type: object
additionalProperties: true
example:
customKey1: "any value we want"
anotherKey: "etc"
required:
- connectionSizeMbps
- destinationAccountId
Expand Down