Add context to activationKey#54
Open
nanditaashok-ms wants to merge 1 commit into
Open
Conversation
nanditaashok-ms
requested review from
VTWoods,
bpescato-amazon and
dkarwowski
as code owners
May 20, 2026 22:46
| Required. User supplied account id/number on the destination CSP. | ||
| Receiving service MUST verify that the activation key was provided from an authorized user of this account. | ||
| type: string | ||
| context: |
Contributor
There was a problem hiding this comment.
This looks good to me.
I would like for us to establish a maximum size here -- being uniform with these numbers will prevent issues in the future.
@nanditaashok-ms As far as you know, would a limit of 500 characters INSIDE the context be reasonable (not counting the "context" key itself)
?
Author
There was a problem hiding this comment.
Yes 500 character limit should be large enough for the content inside of "context"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
As discussed with Brian adding optional field "context"to activationKey which contains key value pairs that can be used to specify the Azure generated servicekey for a Customer connection
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.