Skip to content

Don't switch to "Draft mode"#500

Merged
ppkarwasz merged 2 commits into
gha/v0from
feat/gha/no-draft-mode
Jul 24, 2026
Merged

Don't switch to "Draft mode"#500
ppkarwasz merged 2 commits into
gha/v0from
feat/gha/no-draft-mode

Conversation

@ppkarwasz

Copy link
Copy Markdown
Member

Since GitHub's June 11, 2026 change "Bot-created pull requests can run workflows if approved", workflows triggered by the "Process Dependabot PR" push are no longer silently dropped, but created in an approval-required state. A maintainer can start the required build checks with the "Approve workflows to run" button, so parking the PR in draft mode is no longer necessary.

Also drop the pull-requests: write permission, which was only needed to toggle draft mode, and explicitly opt into persist-credentials for the checkout, since the changelog commit push relies on it.

Assisted-By: Claude Fable 5 noreply@anthropic.com

Since GitHub's June 11, 2026 change "Bot-created pull requests can run
workflows if approved"[1], workflows triggered by the "Process Dependabot
PR" push are no longer silently dropped, but created in an
approval-required state. A maintainer can start the required build checks
with the "Approve workflows to run" button, so parking the PR in draft
mode is no longer necessary.

Also drop the `pull-requests: write` permission, which was only needed to
toggle draft mode, and explicitly opt into `persist-credentials` for the
checkout, since the changelog commit push relies on it.

[1] https://github.blog/changelog/2026-06-11-bot-created-pull-requests-can-run-workflows-if-approved/

Assisted-By: Claude Fable 5 <noreply@anthropic.com>

@ramanathan1504 ramanathan1504 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ppkarwasz

Copy link
Copy Markdown
Member Author

Maybe we can also reenable “Auto-merge”, so we need one less click. I'll modify the PR to do it.

Since the required build checks can now be started with the "Approve
workflows to run" button, restore the pre-#475 behavior of enabling
"auto-merge" on the PR: after a maintainer approves the PR and its
workflow runs, the PR merges automatically once the required checks pass.

Assisted-By: Claude Fable 5 <noreply@anthropic.com>
@ppkarwasz
ppkarwasz enabled auto-merge (squash) July 24, 2026 10:34
@ppkarwasz
ppkarwasz merged commit cf63109 into gha/v0 Jul 24, 2026
2 checks passed
@ppkarwasz
ppkarwasz deleted the feat/gha/no-draft-mode branch July 24, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants