Change build and codeql-analysis triggers#4212
Open
ppkarwasz wants to merge 1 commit into
Open
Conversation
Since apache/logging-parent#500 has been merged, workflow runs no longer need to be triggered by PR events of type `ready_for_review`. We therefore remove the `pull_request.types` filter entirely, which restores the default event types. We also simplify the `branches` filters on the `push` and `pull_request` triggers. Since this workflow file lives on `2.x`, these filters only affect `2.x` itself and branches created from it: - For `push`: only `release/2*` branches automatically inherit these workflows. We drop `2.25.x` (in `build`) and `main` (in `codeql-analysis`), since those entries would only be useful if we were to branch `2.25.x` or `main` anew from `2.x`. Keeping them would confuse readers of the workflow file. - For `pull_request`: all branches will run these workflows if a PR is opened against them (e.g. "stacked" PRs opened against the branch of another PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since apache/logging-parent#500 has been merged, workflow runs no longer need to be triggered by PR events of type
ready_for_review. We therefore remove thepull_request.typesfilter entirely, which restores the default event types.We also simplify the
branchesfilters on thepushandpull_requesttriggers. Since this workflow file lives on2.x, these filters only affect2.xitself and branches created from it:push: onlyrelease/2*branches automatically inherit these workflows. We drop2.25.x(inbuild) andmain(incodeql-analysis), since those entries would only be useful if we were to branch2.25.xormainanew from2.x. Keeping them would confuse readers of the workflow file.pull_request: all branches will run these workflows if a PR is opened against them (e.g. "stacked" PRs opened against the branch of another PR).