Skip to content

chore(ci): Adapt branch camel-4.22.x workflows - #25557

Merged
gansheer merged 1 commit into
apache:camel-4.22.xfrom
gansheer:camel-4.22.x-ci-fix
Aug 20, 2026
Merged

chore(ci): Adapt branch camel-4.22.x workflows#25557
gansheer merged 1 commit into
apache:camel-4.22.xfrom
gansheer:camel-4.22.x-ci-fix

Conversation

@gansheer

@gansheer gansheer commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Ensure we activate the workflows required for camel-4.22.x target.

sonar-build.yml is ignored for now as I am not sure we have the capacity for another branch on sonar

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gansheer
gansheer requested a review from orpiske August 20, 2026 14:25

@atiaomar1978-hub atiaomar1978-hub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

AI-generated review on behalf of atiaomar1978-hub

Focused, correct change: adds camel-4.22.x to the branch triggers for the core PR/push workflows that maintenance-branch contributions need. The diff is minimal and consistent across all six files.

Why CI is failing (not a YAML syntax issue)

The red checks are side effects of editing workflow files, not proof the branch triggers are wrong:

Failed job Root cause
posix-validator (ubuntu + windows) Could not find artifact org.apache.camel:camel-buildtools:jar:4.22.1-SNAPSHOT on Apache Snapshots
camel-launcher-native Pre-flight check 404: camel-launcher/4.22.1-SNAPSHOT not yet on Apache Snapshots
posix-validator (macos) Cancelled (concurrency group)

Both native workflows include their own .github/workflows/*.yml in paths, so this PR triggers them. Those jobs resolve upstream modules from Apache Snapshots instead of building -am locally. The camel-4.22.x branch is at 4.22.1-SNAPSHOT, but that snapshot line has not been deployed yet — expected chicken-and-egg until the first main-build push to camel-4.22.x after merge.

This PR does not cause the missing snapshots; it exposes them by enabling/triggering the workflows.

What looks good

  • Covers the essential workflows: pr-build-main, main-build, doc/CI script validation, and native packaging jobs.
  • Symmetric push + pull_request updates where both exist.
  • Appropriate scope for a maintenance-branch CI bootstrap PR.

Gaps / suggestions (non-blocking)

  1. pr-build-main will not run on this PR — it has paths-ignore: .github/**. To validate CI changes before merge, use workflow_dispatch as documented in the workflow header.
  2. sonar-build.yml still main-only — probably fine (job is currently disabled per INFRA-27808), but worth confirming with maintainers if Sonar should cover camel-4.22.x PRs later.
  3. After merge, ensure a push to camel-4.22.x runs main-build and publishes 4.22.1-SNAPSHOT to Apache Snapshots — otherwise native validation will keep failing on maintenance-branch PRs that touch launcher/exe paths.
  4. Optional follow-up: maintenance-branch native jobs may need a snapshot-absent fallback (local -am build) similar to the camel-launcher-upstream logic already used when camel-jbang-core changes — separate infra improvement, not required for this PR.
  5. PR template checkbox "targeting main" is unchecked — correct since this targets camel-4.22.x; worth noting in the description.

Verdict

Comment — the workflow changes look correct and complete for the stated goal. CI failures are environmental (missing 4.22.1-SNAPSHOT deploy), not a problem with the branch trigger edits. Safe to merge once maintainers accept the snapshot bootstrap sequence.


Review performed with CI log inspection. Does not replace infra team validation.

Comment thread .github/workflows/package-native-validation.yml
@@ -32,6 +33,7 @@ on:
pull_request:
branches:
- main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why camel-launcher-native fails

Same pattern: workflow file change triggers the job. Pre-flight curl for camel-launcher/4.22.1-SNAPSHOT/maven-metadata.xml returns 404 because the maintenance-branch snapshot line hasn't been deployed yet. camel-exe passes because it builds locally; camel-launcher-native resolves upstream from snapshots.

pull_request:
branches:
- main
- camel-4.22.x

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct addition — note paths-ignore

Adding camel-4.22.x here is the most important change for maintenance-branch PR CI. This PR won't exercise it automatically (paths-ignore: .github/**). Use workflow_dispatch to smoke-test after merge.

@atiaomar1978-hub

Copy link
Copy Markdown
Contributor

Review complete

AI-generated on behalf of atiaomar1978-hub

Verdict: Comment (looks good to merge)

Why CI fails

Red checks are not caused by incorrect YAML. Editing package-native-validation.yml and camel-launcher-native-exe.yml triggers those workflows (they watch their own YAML in paths). Those jobs then fail because 4.22.1-SNAPSHOT is not on Apache Snapshots yet (camel-buildtools missing, camel-launcher metadata 404).

Anything missing?

The six updated workflows cover the essentials. Minor notes:

  • pr-build-main won't run on this PR (.github/** ignored) — use workflow_dispatch to test
  • sonar-build.yml still main-only (currently disabled anyway)
  • After merge, first main-build push to camel-4.22.x should publish snapshots so native jobs pass on future PRs

Thanks @gansheer for the maintenance-branch CI bootstrap!

@gansheer
gansheer force-pushed the camel-4.22.x-ci-fix branch from d1e2f0a to be4d481 Compare August 20, 2026 21:35
@gansheer

Copy link
Copy Markdown
Contributor Author

@atiaomar1978-hub thanks for the review.
I will be merging this for now following @gnodet review in #25549 as the lack of ci running on camel-4.22.x is an issue.

@gansheer
gansheer merged commit 1876144 into apache:camel-4.22.x Aug 20, 2026
5 of 9 checks passed
@atiaomar1978-hub

Copy link
Copy Markdown
Contributor

@gansheer Good Luck !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants