chore(ci): Adapt branch camel-4.22.x workflows - #25557
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
atiaomar1978-hub
left a comment
There was a problem hiding this comment.
Review summary
AI-generated review on behalf of atiaomar1978-hub
Focused, correct change: adds camel-4.22.x to the branch triggers for the core PR/push workflows that maintenance-branch contributions need. The diff is minimal and consistent across all six files.
Why CI is failing (not a YAML syntax issue)
The red checks are side effects of editing workflow files, not proof the branch triggers are wrong:
| Failed job | Root cause |
|---|---|
posix-validator (ubuntu + windows) |
Could not find artifact org.apache.camel:camel-buildtools:jar:4.22.1-SNAPSHOT on Apache Snapshots |
camel-launcher-native |
Pre-flight check 404: camel-launcher/4.22.1-SNAPSHOT not yet on Apache Snapshots |
posix-validator (macos) |
Cancelled (concurrency group) |
Both native workflows include their own .github/workflows/*.yml in paths, so this PR triggers them. Those jobs resolve upstream modules from Apache Snapshots instead of building -am locally. The camel-4.22.x branch is at 4.22.1-SNAPSHOT, but that snapshot line has not been deployed yet — expected chicken-and-egg until the first main-build push to camel-4.22.x after merge.
This PR does not cause the missing snapshots; it exposes them by enabling/triggering the workflows.
What looks good
- Covers the essential workflows:
pr-build-main,main-build, doc/CI script validation, and native packaging jobs. - Symmetric
push+pull_requestupdates where both exist. - Appropriate scope for a maintenance-branch CI bootstrap PR.
Gaps / suggestions (non-blocking)
pr-build-mainwill not run on this PR — it haspaths-ignore: .github/**. To validate CI changes before merge, useworkflow_dispatchas documented in the workflow header.sonar-build.ymlstillmain-only — probably fine (job is currently disabled per INFRA-27808), but worth confirming with maintainers if Sonar should covercamel-4.22.xPRs later.- After merge, ensure a push to
camel-4.22.xrunsmain-buildand publishes4.22.1-SNAPSHOTto Apache Snapshots — otherwise native validation will keep failing on maintenance-branch PRs that touch launcher/exe paths. - Optional follow-up: maintenance-branch native jobs may need a snapshot-absent fallback (local
-ambuild) similar to thecamel-launcher-upstreamlogic already used whencamel-jbang-corechanges — separate infra improvement, not required for this PR. - PR template checkbox "targeting main" is unchecked — correct since this targets
camel-4.22.x; worth noting in the description.
Verdict
Comment — the workflow changes look correct and complete for the stated goal. CI failures are environmental (missing 4.22.1-SNAPSHOT deploy), not a problem with the branch trigger edits. Safe to merge once maintainers accept the snapshot bootstrap sequence.
Review performed with CI log inspection. Does not replace infra team validation.
| @@ -32,6 +33,7 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - main | |||
There was a problem hiding this comment.
Why camel-launcher-native fails
Same pattern: workflow file change triggers the job. Pre-flight curl for camel-launcher/4.22.1-SNAPSHOT/maven-metadata.xml returns 404 because the maintenance-branch snapshot line hasn't been deployed yet. camel-exe passes because it builds locally; camel-launcher-native resolves upstream from snapshots.
| pull_request: | ||
| branches: | ||
| - main | ||
| - camel-4.22.x |
There was a problem hiding this comment.
Correct addition — note paths-ignore
Adding camel-4.22.x here is the most important change for maintenance-branch PR CI. This PR won't exercise it automatically (paths-ignore: .github/**). Use workflow_dispatch to smoke-test after merge.
Review completeAI-generated on behalf of atiaomar1978-hub Verdict: Comment (looks good to merge) Why CI failsRed checks are not caused by incorrect YAML. Editing Anything missing?The six updated workflows cover the essentials. Minor notes:
Thanks @gansheer for the maintenance-branch CI bootstrap! |
d1e2f0a to
be4d481
Compare
|
@atiaomar1978-hub thanks for the review. |
|
@gansheer Good Luck ! |
Description
Ensure we activate the workflows required for camel-4.22.x target.
sonar-build.ymlis ignored for now as I am not sure we have the capacity for another branch on sonarTarget
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.