Skip to content

chore(ci): Adapt branch camel-4.22.x workflows - #25549

Closed
gansheer wants to merge 1 commit into
apache:mainfrom
gansheer:camel-4.22.x-ci-fix-main
Closed

chore(ci): Adapt branch camel-4.22.x workflows#25549
gansheer wants to merge 1 commit into
apache:mainfrom
gansheer:camel-4.22.x-ci-fix-main

Conversation

@gansheer

Copy link
Copy Markdown
Contributor

Description

Ensure we activate the workflows required for camel-4.22.x target.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

@squakez squakez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, no idea about how this change will affect the actual pipeline. This has been recently changed a lot by agents. ccing @apupier and @gnodet for any further feedback.

@gansheer
gansheer marked this pull request as ready for review August 19, 2026 08:45

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR targets main but replaces all workflow branch references from main to camel-4.22.x. If merged to main, it would break CI for all PRs targeting main — the build, SonarCloud, native exe, native validation, and CI scripts validation workflows would all stop triggering.

The PR description ("Ensure we activate the workflows required for camel-4.22.x target") confirms this is intended for the maintenance branch. The established pattern on camel-4.18.x is that the maintenance branch's own workflow files reference that branch name — this PR should be retargeted from main to camel-4.22.x.

Additional observations:

  • Inconsistent BASE_REF fallback: pr-build-main.yml updates BASE_REF="${GITHUB_BASE_REF:-main}" to camel-4.22.x (line 93), but sonar-build.yml has the same fallback at line 51 and it is not updated.
  • Missing workflow updates: main-build.yml (line 23 push trigger) and pr-doc-validation.yml (line 22 PR trigger) on camel-4.22.x still reference main — they may also need updating or deletion (on camel-4.18.x, main-build.yml was deleted entirely).

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of @gnodet

@gansheer
gansheer force-pushed the camel-4.22.x-ci-fix-main branch from e8301db to 90ea5c7 Compare August 19, 2026 09:17
@gansheer

Copy link
Copy Markdown
Contributor Author

@gnodet yes sorry, bad cherry-pick.

I am a little confused by the state of camel-4.18.x branch. The branch is not built, only the PR are, but I don't know if it is the intended behavior or an issue on camel-4.18.x. If we want to build the branch we need some change on main. The PR build seem to work for camel-4.18.x.

@gansheer
gansheer force-pushed the camel-4.22.x-ci-fix-main branch from 90ea5c7 to 0522be0 Compare August 19, 2026 09:36
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous concern has been fully addressed — the PR now correctly adds camel-4.22.x alongside main in workflow branch triggers (instead of replacing main), making it safe to merge to main. CI is green. 👍

Minor observations:

  • sonar-build.yml is not updated to include camel-4.22.x in its pull_request.branches filter, but since the workflow is currently disabled (if: false && ... at line 41), this is very low priority.
  • These changes on main are essentially a no-op for immediate CI behavior, because GitHub Actions evaluates workflow triggers from the files on the target branch. A follow-up cherry-pick to camel-4.22.x may be needed to actually activate CI there.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of @gnodet

@gansheer

Copy link
Copy Markdown
Contributor Author

@gnodet replaces by #25557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants