chore(ci): Adapt branch camel-4.22.x workflows - #25549
Conversation
gnodet
left a comment
There was a problem hiding this comment.
This PR targets main but replaces all workflow branch references from main to camel-4.22.x. If merged to main, it would break CI for all PRs targeting main — the build, SonarCloud, native exe, native validation, and CI scripts validation workflows would all stop triggering.
The PR description ("Ensure we activate the workflows required for camel-4.22.x target") confirms this is intended for the maintenance branch. The established pattern on camel-4.18.x is that the maintenance branch's own workflow files reference that branch name — this PR should be retargeted from main to camel-4.22.x.
Additional observations:
- Inconsistent
BASE_REFfallback:pr-build-main.ymlupdatesBASE_REF="${GITHUB_BASE_REF:-main}"tocamel-4.22.x(line 93), butsonar-build.ymlhas the same fallback at line 51 and it is not updated. - Missing workflow updates:
main-build.yml(line 23 push trigger) andpr-doc-validation.yml(line 22 PR trigger) oncamel-4.22.xstill referencemain— they may also need updating or deletion (oncamel-4.18.x,main-build.ymlwas deleted entirely).
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of @gnodet
e8301db to
90ea5c7
Compare
|
@gnodet yes sorry, bad cherry-pick. I am a little confused by the state of camel-4.18.x branch. The branch is not built, only the PR are, but I don't know if it is the intended behavior or an issue on camel-4.18.x. If we want to build the branch we need some change on main. The PR build seem to work for camel-4.18.x. |
90ea5c7 to
0522be0
Compare
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
left a comment
There was a problem hiding this comment.
The previous concern has been fully addressed — the PR now correctly adds camel-4.22.x alongside main in workflow branch triggers (instead of replacing main), making it safe to merge to main. CI is green. 👍
Minor observations:
sonar-build.ymlis not updated to includecamel-4.22.xin itspull_request.branchesfilter, but since the workflow is currently disabled (if: false && ...at line 41), this is very low priority.- These changes on
mainare essentially a no-op for immediate CI behavior, because GitHub Actions evaluates workflow triggers from the files on the target branch. A follow-up cherry-pick tocamel-4.22.xmay be needed to actually activate CI there.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of @gnodet
Description
Ensure we activate the workflows required for
camel-4.22.xtarget.Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.