Skip to content

ci: GHA workflow security cleanup #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emptyhammond merged 4 commits into from
May 28, 2026
Merged

ci: GHA workflow security cleanup #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6861d3
ci: disable credential persistence on checkout
emptyhammond May 27, 2026
231062a
ci: scope workflow and job permissions explicitly
emptyhammond May 27, 2026
b004d01
ci: pass only required secret to reusable workflow
emptyhammond May 27, 2026
34cb295
ci: pin third-party actions to commit SHAs
emptyhammond May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,23 @@ on:

name: Check

permissions: {}

jobs:
check:
name: Check
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2
with:
submodules: 'recursive'
persist-credentials: false

- name: Setup Rust Toolchain
uses: actions-rs/toolchain@v1
uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # v1
with:
profile: minimal
toolchain: stable
Expand All @@ -26,20 +31,20 @@ jobs:
run: rustc -V

- name: cargo check
uses: actions-rs/cargo@v1
uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1
with:
command: check

- name: cargo test
uses: actions-rs/cargo@v1
uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1
with:
command: test

- name: Install rustfmt
run: rustup component add rustfmt

- name: cargo fmt
uses: actions-rs/cargo@v1
uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1
with:
command: fmt
args: --all -- --check
Expand All @@ -48,7 +53,7 @@ jobs:
run: rustup component add clippy

- name: cargo clippy
uses: actions-rs/cargo@v1
uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1
with:
command: clippy
args: -- -D warnings
11 changes: 9 additions & 2 deletions .github/workflows/features.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,16 @@ on:
branches:
- main

permissions: {}

jobs:
build:
uses: ably/features/.github/workflows/sdk-features.yml@main
permissions:
contents: read
deployments: write
id-token: write
uses: ably/features/.github/workflows/sdk-features.yml@6b3fc7a8ede2ebdd7a6325314f3a96c6466f1453 # main
with:
repository-name: ably-rust
secrets: inherit
secrets:
ABLY_AWS_ACCOUNT_ID_SDK: ${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}
Loading