ci: GHA workflow security cleanup#36
Merged
Merged
Conversation
Set persist-credentials: false on actions/checkout so the default GITHUB_TOKEN is not left in the local git config after the checkout step completes.
Add a top-level permissions: {} block to each workflow so no
GITHUB_TOKEN scopes are granted by default, then grant each job only
the scopes it actually needs:
- check.yml's check job: contents: read for checkout
- features.yml's build job: contents: read for checkout, plus
deployments: write and id-token: write to match what the called
reusable workflow declares it needs
Replace secrets: inherit, which forwards every secret available to the calling workflow, with an explicit pass-through of just ABLY_AWS_ACCOUNT_ID_SDK — the only secret the called workflow declares as required.
lmars
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine hygiene pass over the GitHub Actions workflows in this repo, addressing findings from a workflow security audit. Changes are split into four commits, one per finding type:
check job; contents: read plus the deployments: write / id-token: write that the called reusable workflow declares it needs).
so unrelated secrets are not forwarded.
branch move can't silently change what runs in CI.