Update newsletter form to match latest Figma design - #318
Closed
MohamedFazil1406 wants to merge 9 commits into
Closed
Update newsletter form to match latest Figma design#318MohamedFazil1406 wants to merge 9 commits into
MohamedFazil1406 wants to merge 9 commits into
Conversation
…ructure Introducing SDD structure for Services Page
…b-issues Updating SDD docs to include new Service page issues
👷 Deploy request for webdevpathstage pending review.Visit the deploys page to approve it
|
Member
|
Hi, it seems other changes in the service branch was included in the PR. Could you see if you're able to only include buttons and input style update? If it's too complicated we could just merge this into service-dev (after we have a decision for the other PR #315 Also if it's not possible to easily update variables (just the ones used in this PR, we will slowly convert all of them) to the new ones listed in the figma. I could open another issue, to update all of them separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the newsletter form to align with the latest Figma design.
Issue #317
Changes
Testing
yarn buildcompletes successfully.