style(newsletter): update newsletter form to match latest Figma design - #319
style(newsletter): update newsletter form to match latest Figma design#319MohamedFazil1406 wants to merge 1 commit into
Conversation
👷 Deploy request for webdevpathstage pending review.Visit the deploys page to approve it
|
|
Hi, thanks for your quick update. Could you please let us know what you think about this from the closed PR #318
I can also see a few issues,
Thanks! |
|
Thanks! I looked into updating the variables used in this PR. I couldn't find the new Figma token names implemented throughout the project, so I kept the existing variables to avoid introducing inconsistent tokens. If you'd prefer, I'm happy to update just the variables used in this PR if those tokens are available. Otherwise, I think handling the full design token migration in a separate issue would keep this PR focused on the newsletter styling changes. |
@MohamedFazil1406 Hi, sorry didn't get notification for this. Feel free to ping me on slack or here in future if I don't respond within a day or two I put a link in the issue for the new design token name in the issue
It looks like this, it's under I'm ok if you keep existing names for this PR, but use new tokens for newly introduced variables, then we can do another PR for updates later |


Summary
This PR updates the newsletter form styling to match the latest Figma design.
###Issue #317
Changes
CHANGELOG.md.Testing
yarn buildcompleted successfully.