Skip to content

style(newsletter): update newsletter form to match latest Figma design - #319

Open
MohamedFazil1406 wants to merge 1 commit into
Web-Dev-Path:mainfrom
MohamedFazil1406:feature/newsletter-figma-update
Open

style(newsletter): update newsletter form to match latest Figma design#319
MohamedFazil1406 wants to merge 1 commit into
Web-Dev-Path:mainfrom
MohamedFazil1406:feature/newsletter-figma-update

Conversation

@MohamedFazil1406

Copy link
Copy Markdown
Member

Summary

This PR updates the newsletter form styling to match the latest Figma design.

###Issue #317

Changes

  • Updated newsletter input styles to match the latest design.
  • Updated subscribe button typography and styling.
  • Improved spacing and responsiveness for the newsletter form.
  • Updated CHANGELOG.md.

Testing

  • ✅ Tested on mobile, tablet, desktop, and large desktop viewports.
  • ✅ Verified that shared components continue to work as expected.
  • yarn build completed successfully.

@netlify

netlify Bot commented Jul 29, 2026

Copy link
Copy Markdown

👷 Deploy request for webdevpathstage pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit eb57006

@cherylli

Copy link
Copy Markdown
Member

Hi, thanks for your quick update.

Could you please let us know what you think about this from the closed PR #318
Since this is one of the acceptance criteria

Also if it's not possible to easily update variables (just the ones used in this PR, we will slowly convert all of them) to the new ones listed in the figma. I could open another issue, to update all of them separately.

I can also see a few issues,

  1. the button is not updated to the new design
  2. > needs to be removed based on the design
  3. the input sizes are uneven in the desktop view at 1440px width
image

Thanks!

@MohamedFazil1406

Copy link
Copy Markdown
Member Author

Thanks! I looked into updating the variables used in this PR. I couldn't find the new Figma token names implemented throughout the project, so I kept the existing variables to avoid introducing inconsistent tokens. If you'd prefer, I'm happy to update just the variables used in this PR if those tokens are available. Otherwise, I think handling the full design token migration in a separate issue would keep this PR focused on the newsletter styling changes.

@cherylli

cherylli commented Aug 5, 2026

Copy link
Copy Markdown
Member

Thanks! I looked into updating the variables used in this PR. I couldn't find the new Figma token names implemented throughout the project, so I kept the existing variables to avoid introducing inconsistent tokens. If you'd prefer, I'm happy to update just the variables used in this PR if those tokens are available. Otherwise, I think handling the full design token migration in a separate issue would keep this PR focused on the newsletter styling changes.

@MohamedFazil1406 Hi, sorry didn't get notification for this. Feel free to ping me on slack or here in future if I don't respond within a day or two

I put a link in the issue for the new design token name in the issue

Rename variables base on dev tokens on the figma file https://www.figma.com/design/Fp0lLB5OWZLJseTs2svGbg/Web-Dev-Path_design?node-id=80-479

It looks like this, it's under Foundations (Devs)
image

I'm ok if you keep existing names for this PR, but use new tokens for newly introduced variables, then we can do another PR for updates later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants