fix(relay-auth): reject expired JWTs in verifyJWT - #279
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
signJWT always sets exp, but verifyJWT only checked the EdDSA signature, so a captured relay JWT remained valid forever. Fail closed on missing or stale exp after signature verification. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
|
Thank you for your contribution! We ask that you please read and sign our CTA Document before we can accept your contribution. You can sign the CTA simply by posting a Pull Request Comment with the following text: I have read the CTA Document and I hereby sign the CTA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@walletconnect/relay-authsignJWTalways setsexp, butverifyJWTonly checked the EdDSA signature.verifyJWTuntil the client key rotates.payload.expand reject whenexp <= now.Sibling of open cacao #278 (distinct surface).
Test plan
npm run build -- --filter=./relay/relay-auth && npm test --workspace=@walletconnect/relay-auth→ 6/6Tooling assist used for prep; commit authored/signed by me (no Cursor co-author trailer).
Made with Cursor