fix(cacao): reject CR/LF in all SIWE single-line fields - #280
Open
SashaMIT wants to merge 2 commits into
Open
Conversation
Parity with @walletconnect/utils: embedded CR/LF in statement can forge later EIP-4361 fields (URI, Nonce) in the reconstructed signed message.
|
All contributors have signed the CTA ✍️ ✅ |
Extend formatMessage beyond statement so domain, aud, version, nonce, iat (and optional exp/nbf/requestId) cannot smuggle EIP-4361 lines. Parity with walletconnect-monorepo formatMessage.
SashaMIT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatMessagepreviously only rejected line breaks instatement. Caller-supplieddomain,aud,version,nonce,iat(and optionalexp/nbf/requestId) could still embed\r/\nand forge later EIP-4361 fields (for example a smuggledURI:line).This extends the same single-line reject to those fields. Parity with
@walletconnect/utilsformatMessagein walletconnect-monorepo (#7311).Test plan
formatMessage.test.tscovers statement, domain, aud, nonce (6/6 withTEST_PROJECT_IDstub for suite load)