-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26172_OWNER_033-governance-hygiene-closeout #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Instruction Compliance Checklist | ||
|
|
||
| PR: $pr | ||
|
|
||
| - [x] Read docs_build/dev/PROJECT_INSTRUCTIONS.md. | ||
| - [x] Read docs_build/dev/PROJECT_MULTI_PC.txt. | ||
| - [x] Verified current branch was the approved OWNER workstream branch before PR 033 branch creation. | ||
| - [x] Verified repository was clean/synced before PR 033 edits. | ||
| - [x] Verified PR TEAM token is OWNER. | ||
| - [x] Verified OWNER governance closeout scope matches TEAM ownership. | ||
| - [x] Updated only scoped governance backlog and required reports. | ||
| - [x] Ran git diff --check. | ||
| - [x] Verified Workstream Hygiene governance exists. | ||
| - [x] Verified PI Closeout governance exists. | ||
| - [x] Verified GitHub Hygiene Audit governance exists. | ||
| - [x] Verified EOD Workstream Closeout governance exists. | ||
| - [x] Verified GitHub-authoritative workstream controls exist. | ||
| - [x] Verified Sequential Codex Queue governance exists. | ||
| - [x] Verified Alpha/Beta/Gamma ownership governance exists. | ||
| - [x] Documented skipped Playwright and samples lanes. | ||
| - [x] Created required Codex reports. | ||
| - [x] Created repo-structured delta ZIP under mp/. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Manual Validation Notes | ||
|
|
||
| PR: $pr | ||
|
|
||
| ## Checks Performed | ||
|
|
||
| - Verified Workstream Hygiene governance exists. | ||
| - Verified PI Closeout governance exists. | ||
| - Verified GitHub Hygiene Audit governance exists. | ||
| - Verified EOD Workstream Closeout governance exists. | ||
| - Verified GitHub-authoritative workstream controls through push, local/origin sync, and GitHub hygiene audit requirements. | ||
| - Verified Sequential Codex Queue governance through the all-team sequential PR execution model. | ||
| - Verified Alpha/Beta/Gamma ownership governance in the authoritative team ownership map and NATO-normalized active ProjectInstructions team names. | ||
| - Confirmed no runtime code changed. | ||
| - Confirmed no feature work was added. | ||
| - Confirmed no branch deletion or PR closure was performed. | ||
|
|
||
| ## Manual Result | ||
|
|
||
| PASS | ||
|
|
||
| ## Skipped Validation | ||
|
|
||
| - Playwright was not run because no UI or runtime behavior changed. | ||
| - Samples were not run because no samples or sample-impacting runtime changed. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,6 @@ | ||
| docs_build/dev/PROJECT_INSTRUCTIONS.md | ||
| docs_build/dev/ProjectInstructions/addendums/multi_team.md | ||
| docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance-instruction-compliance-checklist.md | ||
| docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance-manual-validation-notes.md | ||
| docs_build/dev/reports/PR_26172_OWNER_030-workstream-hygiene-governance.md | ||
| docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-instruction-compliance-checklist.md | ||
| docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance-manual-validation-notes.md | ||
| docs_build/dev/reports/PR_26172_OWNER_031-pi-closeout-governance.md | ||
| docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-instruction-compliance-checklist.md | ||
| docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-manual-validation-notes.md | ||
| docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template.md | ||
| docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When this PR is reviewed through the required Codex artifacts, this file contains only bare paths, but Useful? React with 👍 / 👎. |
||
| docs_build/dev/reports/PR_26172_OWNER_033-governance-hygiene-closeout-governance-closeout-report.md | ||
| docs_build/dev/reports/PR_26172_OWNER_033-governance-hygiene-closeout-manual-validation-notes.md | ||
| docs_build/dev/reports/PR_26172_OWNER_033-governance-hygiene-closeout-instruction-compliance-checklist.md | ||
| docs_build/dev/reports/codex_changed_files.txt | ||
| docs_build/dev/reports/codex_review.diff | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new manual validation file only records
PR: $prbefore the checks and never states the required TEAM ownership, even thoughdocs_build/dev/PROJECT_INSTRUCTIONS.mdline 45 requires manual validation notes to include TEAM ownership. For OWNER closeout audits this leaves the required validation artifact without the ownership evidence it is supposed to carry; add an explicit TEAM/ownership entry here.Useful? React with 👍 / 👎.