PR_26172_OWNER_033-governance-hygiene-closeout#78
Conversation
There was a problem hiding this comment.
💡 Codex Review
In this docs-only closeout, these evidence rows contain embedded NUL/BEL control characters (sync \0 0 and \a ddendums), which makes Git classify the markdown report as binary and causes codex_review.diff to store it as an unreadable binary patch. This corrupts the cited evidence text and defeats the review artifact's purpose; rewrite these rows as plain text paths/statuses.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-instruction-compliance-checklist.md | ||
| docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template-manual-validation-notes.md | ||
| docs_build/dev/reports/PR_26172_OWNER_032-github-hygiene-audit-template.md | ||
| docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md |
There was a problem hiding this comment.
Populate changed-files report with command output
When this PR is reviewed through the required Codex artifacts, this file contains only bare paths, but docs_build/dev/PROJECT_INSTRUCTIONS.md lines 798-800 require codex_changed_files.txt to include git status --short and git diff --stat. Without the status prefixes and diffstat, the artifact no longer records the file statuses or scope summary reviewers are instructed to use.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,25 @@ | |||
| # Manual Validation Notes | |||
|
|
|||
| PR: $pr | |||
There was a problem hiding this comment.
Add TEAM ownership to manual validation notes
This new manual validation file only records PR: $pr before the checks and never states the required TEAM ownership, even though docs_build/dev/PROJECT_INSTRUCTIONS.md line 45 requires manual validation notes to include TEAM ownership. For OWNER closeout audits this leaves the required validation artifact without the ownership evidence it is supposed to carry; add an explicit TEAM/ownership entry here.
Useful? React with 👍 / 👎.
Summary
Stack
pr/26172-OWNER-030-workstream-and-pi-hygiene-governanceFiles Changed
docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.mddocs_build/dev/reports/PR_26172_OWNER_033-governance-hygiene-closeout-governance-closeout-report.mddocs_build/dev/reports/PR_26172_OWNER_033-governance-hygiene-closeout-manual-validation-notes.mddocs_build/dev/reports/PR_26172_OWNER_033-governance-hygiene-closeout-instruction-compliance-checklist.mddocs_build/dev/reports/codex_changed_files.txtdocs_build/dev/reports/codex_review.diffValidation
git diff --checkgit diff --cached --checkPackage
tmp/PR_26172_OWNER_033-governance-hygiene-closeout_delta.zipGuardrails
main.mainperformed.