Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# PR_26171_BETA_083 Dead-Code Cleanup Checklist

## Message Studio
- PASS: Removed duplicate preview TTS Profile control outside the table.
- PASS: Removed duplicate TTS service selector outside the table.
- PASS: Removed dead Test Speech button and selected-item helper text.
- PASS: Removed unused Message Studio speech-test state and render paths.
- PASS: Kept playback routed through selected message part, TTS Profile, and Emotion Setting.
- PASS: Kept Play Part, Play Message, and Stop Playback controls available.

## TTS Studio
- PASS: Kept Delivery in Emotion Settings.
- PASS: Kept Presets in Emotion Settings as Delivery Preset.
- PASS: Kept Voice Filters in profile controls.
- PASS: No duplicate summary or output panel was added.
- PASS: No separate Emotion Studio was added.

## Tests
- PASS: Removed dead Message speech-test selector expectations.
- PASS: Added absence checks for removed duplicate controls.
- PASS: Added actionable error coverage for missing TTS Profile.
- PASS: Added actionable error coverage for missing Emotion Setting on the selected profile.
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# PR_26171_BETA_083 Manual Validation Notes

## Manual Review
- Reviewed changed Message Studio markup for removed duplicate controls.
- Reviewed changed Message Studio JavaScript for removed speech-test state and render paths.
- Reviewed changed TTS Studio labels for Profile, Age Filter, and Delivery Preset wording.
- Reviewed Playwright coverage for missing TTS Profile and missing Emotion Setting error states.

## Browser Validation
- Targeted Playwright validation covered Message Studio and TTS Studio flows.
- No separate manual browser session was required beyond the automated browser validation.

## Packaging
- Delta ZIP is required under tmp/ and must not be staged.
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# PR_26171_BETA_083 Message/TTS UX Checklist

## Message Studio
- PASS: Messages parent table label is creator-friendly.
- PASS: Message Parts child table uses Part Text, Emotion, TTS Profile, Status, and Actions.
- PASS: Play Part label remains clear.
- PASS: Play Message label remains clear.
- PASS: Stop control is labeled Stop Playback.
- PASS: Missing TTS Profile produces a visible actionable error.
- PASS: Missing Emotion Setting on the selected TTS Profile produces a visible actionable error.
- PASS: Duplicate TTS/Profile/Emotion controls were not left outside the tables.

## TTS Studio
- PASS: TTS Profile parent table uses creator-friendly Profile labeling.
- PASS: Age is clarified as Age Filter.
- PASS: Emotion Settings child table uses Delivery Preset labeling.
- PASS: Delivery settings live in Emotion Settings.
- PASS: Presets live in Emotion Settings.
- PASS: Voice Filters live only in profile controls.
- PASS: Duplicate summary/output panels were not introduced.

## Ownership
- PASS: Message Studio owns text, ordered message parts, Emotion selection, and TTS Profile selection.
- PASS: TTS Studio owns Voice, Language, Emotion Settings, Delivery, and Presets.
- PASS: src/engine/audio owns playback.
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# PR_26171_BETA_083 Validation Report

## Static Checks
- PASS: node --check toolbox/messages/messages.js
- PASS: node --check toolbox/text-to-speech/text2speech.js
- PASS: node --check tests/playwright/tools/MessagesTool.spec.mjs
- PASS: node --check tests/playwright/tools/TextToSpeechFunctional.spec.mjs

## Targeted Message Studio Validation
- PASS: npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --reporter=list
- Result: 3 passed in 38.3s

## Targeted TTS Studio Validation
- PASS: npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --reporter=list
- Result: 3 passed in 53.1s

## Project Workspace Validation
- PASS: npm run test:workspace-v2
- Result: 5 passed in 1.7m
- Note: Command name is legacy; user-facing language is Project Workspace.

## Validation Notes
- A first parallel Message Studio run timed out while TTS validation was also running. The Message Studio suite passed on the targeted rerun.
- Generated workspace report churn was restored before PR report files were written.
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# PR_26171_BETA_083-message-tts-polish-and-dead-code

## Summary
- Team: BETA
- Scope: Message Studio and TTS Studio polish after parent/child table and playback integration.
- Branch: pr/26171-BETA-083-message-tts-polish-and-dead-code
- Instruction compliance: PASS

## Ownership Confirmation
- BETA owns Message Studio work.
- BETA owns TTS Studio and TextToSpeechEngine integration work.
- Message Studio owns message text, ordered message parts, Emotion selection, and TTS Profile selection.
- TTS Studio owns profiles, voices, language, per-profile emotion settings, Delivery, and Presets.
- src/engine/audio owns playback.

## Changes
- Removed dead Message Studio speech-test controls and unused selection code.
- Replaced Message Studio speech-test status with playback readiness/status.
- Kept Message Studio playback controls visible and clarified Stop as Stop Playback.
- Updated Message parent and part table labels to be more creator-friendly.
- Added explicit missing TTS Profile and missing Emotion Setting validation coverage.
- Clarified TTS Profile table and Emotion Settings table labels.
- Clarified that TTS presets belong to Emotion Settings as Delivery Preset.

## Architecture Notes
- Theme V2 only.
- External JavaScript only.
- No inline styles, style blocks, inline handlers, page-local CSS, or tool-local CSS were added.
- No database changes.
- No separate Emotion Studio was added.
- Browser-owned product data was not introduced as a source of truth.
- Silent fallback for an explicitly stale TTS Profile selection was removed.

## Validation Summary
- PASS: node --check toolbox/messages/messages.js
- PASS: node --check toolbox/text-to-speech/text2speech.js
- PASS: node --check tests/playwright/tools/MessagesTool.spec.mjs
- PASS: node --check tests/playwright/tools/TextToSpeechFunctional.spec.mjs
- PASS: npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --reporter=list
- PASS: npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --reporter=list
- PASS: npm run test:workspace-v2

## Notes
- The first parallel Message Studio Playwright run timed out during report contention; the targeted Message Studio rerun passed by itself.
- npm run test:workspace-v2 is a legacy command name; user-facing language remains Project Workspace.
138 changes: 13 additions & 125 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,125 +1,13 @@
PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff

Git workflow:
- Current branch: pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
- Created branch: pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
- Push result: PASS; pushed to origin/pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
- PR URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/32
- Merge approval status: pending explicit Team Alpha owner approval
- Merge result: not performed; merge is blocked until explicit Team Alpha owner approval
- Rebase/conflict resolution: PASS; rebased onto origin/main at e8845dae6 after GitHub reported the branch was behind current main. Conflicts were limited to generated Codex report artifacts and reports were regenerated.
- Latest rebase/conflict resolution: PASS; rebased onto origin/main at 195c90a64 after PR_26171_BETA_075 landed. Conflicts were resolved in generated Codex report artifacts and tests/playwright/tools/RootToolsFutureState.spec.mjs; the test expectations now preserve current-main Text To Speech coverage and ALPHA_047 canonical game-hub route/filter behavior.
- Final approved rebase: PASS; Team Alpha approval granted for ALPHA_047, rebased onto origin/main at 1451a1173, with conflicts limited to generated Codex report artifacts.

Instruction compliance:
- PASS: docs_build/dev/PROJECT_INSTRUCTIONS.md was read before file changes.
- PASS: docs_build/dev/PROJECT_MULTI_PC.txt was read before file changes.
- PASS: BUILD_PR.md was created and read before implementation.
- PASS: Team Alpha owner scope applies to Game Hub, Game Journey handoff, and Idea Board continuity.
- PASS: Full samples smoke was not run.

Validation:
- PASS: node --check toolbox/game-hub/game-hub.js
- PASS: node --check toolbox/game-hub/game-hub-api-client.js
- PASS: node --check toolbox/idea-board/index.js
- PASS: node --check toolbox/game-journey/game-journey.js
- PASS: node --check src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
- PASS: node --check src/dev-runtime/server/local-api-router.mjs
- PASS: node --check tests/playwright/tools/GameHubMockRepository.spec.mjs
- PASS: node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
- PASS: node --check tests/playwright/tools/GameJourneyTool.spec.mjs
- PASS: npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --project=playwright --workers=1 --reporter=line (11 passed)
- PASS: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line (2 passed)
- PASS: npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=line --grep "Game Hub hands the active game route to Game Journey|Game Journey requires an active game" (2 passed)
- PASS: npm run test:workspace-v2 (5 passed)
- PASS: git diff --check (line-ending warnings only)
- PASS: Completion revalidation for PR_26171_ALPHA_048 start-gate blocker; ALPHA_047 scoped validation was rerun while still on branch pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff, and ALPHA_048 implementation was not started.
- PASS: Latest post-rebase validation after origin/main 195c90a64: syntax checks, targeted Game Hub Playwright, targeted Idea Board Playwright, targeted Game Journey handoff Playwright, and npm run test:workspace-v2.
- PASS: Final approved validation after origin/main 1451a1173: syntax checks, targeted Game Hub Playwright, targeted Idea Board Playwright, targeted Game Journey handoff Playwright, and npm run test:workspace-v2.

Requirement-by-requirement evidence:
- PASS: Rename active path toolbox/game-workspace/ to toolbox/game-hub/.
- PASS: Rename active game-workspace.js to game-hub.js.
- PASS: Rename active game-workspace-api-client.js to game-hub-api-client.js.
- PASS: Deep-audit and update imports, variables, data attributes, tests, toolbox navigation/registry, tool display mode slug, page titles, and creator-facing labels to Game Hub.
- PASS: Do not leave active navigation pointing to toolbox/game-workspace; active route audit found no active legacy route.
- PASS: Do not create duplicate active Game Hub paths; registry reads filter stale game-workspace rows and active metadata points to game-hub.
- PASS: Idea Board Create Project creates/links a Game Hub project when a Ready idea becomes Project.
- PASS: Project ideas lock original Idea, Pitch, and Notes.
- PASS: Game Hub shows Source Idea/Pitch/Notes as read-only creator-facing content.
- PASS: Game Journey receives executable Journey items from Idea notes when the linked project opens.
- PASS: Original Idea notes are not mutated or moved.
- PASS: Project/source-linked actions avoid Delete and use Open in Game Hub plus Archive.
- PASS: No real database migration was added; existing shared mock/server contracts are reused.
- PASS: Merge is not performed without explicit Team Alpha owner approval.

Changed files:
- deleted: assets/theme-v2/images/badges/game-workspace-1024.png
- deleted: assets/theme-v2/images/badges/game-workspace.png
- added: assets/theme-v2/images/badges/game-hub-1024.png
- added: assets/theme-v2/images/badges/game-hub.png
- deleted: assets/theme-v2/images/tools/game-workspace-1024.png
- deleted: assets/theme-v2/images/tools/game-workspace.png
- added: assets/theme-v2/images/tools/game-hub-1024.png
- added: assets/theme-v2/images/tools/game-hub.png
- updated: assets/theme-v2/js/account-achievements.js
- updated: assets/theme-v2/js/gamefoundry-partials.js
- updated: assets/theme-v2/partials/header-nav.html
- updated: docs_build/database/ddl/game-workspace.sql
- updated: docs_build/database/dml/DML_INDEX.md
- updated: docs_build/database/dml/game-workspace.sql
- updated: docs_build/database/seed/game-workspace.json
- updated: docs_build/database/seed/guest/game-workspace.json
- updated: docs_build/dev/admin-notes/deployment-uat-prod/index.txt
- added: docs_build/dev/reports/codex_changed_files.txt
- added: docs_build/dev/reports/codex_review.diff
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/APPLY_PR.md
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/BUILD_PR.md
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/PLAN_PR.md
- deleted: learn/game-workspace/index.html
- added: learn/game-hub/index.html
- updated: learn/getting-started/index.html
- updated: learn/index.html
- updated: package.json
- updated: scripts/run-targeted-test-lanes.mjs
- updated: scripts/validate-browser-env-agnostic.mjs
- updated: scripts/validate-local-postgres-runtime.mjs
- updated: src/dev-runtime/admin/header-nav.local.html
- updated: src/dev-runtime/persistence/mock-db-store.js
- updated: src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
- updated: src/dev-runtime/seed/server-seed-loader.mjs
- updated: src/dev-runtime/server/local-api-router.mjs
- updated: src/shared/toolbox/tool-metadata-inventory.js
- updated: tests/dev-runtime/DevRuntimeBoundary.test.mjs
- updated: tests/dev-runtime/ProductDataProviderContractHardening.test.mjs
- updated: tests/dev-runtime/SupabaseProductDataCutover.test.mjs
- updated: tests/playwright/account/AchievementsPage.spec.mjs
- updated: tests/playwright/tools/AdminDbViewer.spec.mjs
- added: tests/playwright/tools/GameHubMockRepository.spec.mjs
- updated: tests/playwright/tools/GameJourneyTool.spec.mjs
- deleted: tests/playwright/tools/GameWorkspaceMockRepository.spec.mjs
- updated: tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
- updated: tests/playwright/tools/RootToolsFutureState.spec.mjs
- updated: tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs
- updated: tests/playwright/tools/ToolImageRegistry.spec.mjs
- updated: tests/playwright/tools/ToolNavigationPrevNext.spec.mjs
- updated: tests/playwright/tools/ToolboxRoutePages.spec.mjs
- updated: toolbox/colors/index.html
- updated: toolbox/controls/controls.js
- updated: toolbox/controls/index.html
- updated: toolbox/game-design/index.html
- added: toolbox/game-hub/game-hub-api-client.js
- added: toolbox/game-hub/game-hub.js
- added: toolbox/game-hub/index.html
- updated: toolbox/game-journey/game-journey.js
- deleted: toolbox/game-workspace/game-workspace-api-client.js
- deleted: toolbox/game-workspace/game-workspace.js
- deleted: toolbox/game-workspace/index.html
- updated: toolbox/idea-board/index.js
- updated: toolbox/project-workspace/index.html
- updated: toolbox/tools-page-accordions.js

ZIP:
- Path: tmp/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff_delta.zip
- Size: generated after branch push; final byte size is reported in the delivery response because the ZIP is not committed.
- Contents: repo-structured scoped delta files. Deleted legacy paths are documented in the changed-files list and are not represented as physical files in the archive.
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-dead-code-cleanup-checklist.md
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-message-tts-ux-checklist.md
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-validation-report.md
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code.md
tests/playwright/tools/MessagesTool.spec.mjs
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
toolbox/messages/index.html
toolbox/messages/messages.js
toolbox/text-to-speech/index.html
toolbox/text-to-speech/text2speech.js
Loading
Loading