PR_26171_BETA_083-message-tts-polish-and-dead-code#42
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fececdc034
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const segmentProfileKey = state.segmentTtsProfileKeys.get(segmentKey); | ||
| if (segmentProfileKey) { | ||
| return ttsProfileOptionByKey(segmentProfileKey); | ||
| } |
There was a problem hiding this comment.
Preserve missing part-profile errors during message playback
When a part has a selected TTS profile key that is no longer present or active, this branch now returns null; however playMessage treats that null as if the part had no override and falls back to the message profile, so playing the whole message silently uses the wrong profile instead of surfacing the new missing-profile validation. This affects the exact stale/missing-profile case added in this change and is inconsistent with Play Part, which reports the error.
Useful? React with 👍 / 👎.
Summary
Team Ownership
Validation
Reports