Skip to content

PR_26171_BETA_083-message-tts-polish-and-dead-code#42

Merged
ToolboxAid merged 1 commit into
mainfrom
pr/26171-BETA-083-message-tts-polish-and-dead-code
Jun 21, 2026
Merged

PR_26171_BETA_083-message-tts-polish-and-dead-code#42
ToolboxAid merged 1 commit into
mainfrom
pr/26171-BETA-083-message-tts-polish-and-dead-code

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Polish Message Studio and TTS Studio after parent/child table and playback integration.
  • Remove dead Message speech-test controls and unused render/state paths.
  • Clarify creator-facing Message/TTS table labels and playback status labels.
  • Add coverage for visible actionable errors when TTS Profile or Emotion Settings are missing.

Team Ownership

  • Team: BETA
  • Message Studio owns text, ordered message parts, Emotion selection, and TTS Profile selection.
  • TTS Studio owns profiles, voice, language, per-profile emotion settings, Delivery, and Presets.
  • src/engine/audio owns playback.

Validation

  • PASS: node --check toolbox/messages/messages.js
  • PASS: node --check toolbox/text-to-speech/text2speech.js
  • PASS: node --check tests/playwright/tools/MessagesTool.spec.mjs
  • PASS: node --check tests/playwright/tools/TextToSpeechFunctional.spec.mjs
  • PASS: npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --reporter=list
  • PASS: npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --reporter=list
  • PASS: npm run test:workspace-v2

Reports

  • docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code.md
  • docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-dead-code-cleanup-checklist.md
  • docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-message-tts-ux-checklist.md
  • docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-validation-report.md
  • docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-manual-validation-notes.md
  • tmp/PR_26171_BETA_083-message-tts-polish-and-dead-code_delta.zip

@ToolboxAid ToolboxAid merged commit 06d4a0f into main Jun 21, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fececdc034

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +297 to +300
const segmentProfileKey = state.segmentTtsProfileKeys.get(segmentKey);
if (segmentProfileKey) {
return ttsProfileOptionByKey(segmentProfileKey);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve missing part-profile errors during message playback

When a part has a selected TTS profile key that is no longer present or active, this branch now returns null; however playMessage treats that null as if the part had no override and falls back to the message profile, so playing the whole message silently uses the wrong profile instead of surfacing the new missing-profile validation. This affects the exact stale/missing-profile case added in this change and is inconsistent with Play Part, which reports the error.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants