Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# PR_26171_006 Manual Validation Notes

- Confirmed targeted Playwright flow opens the Theme V2 Messages tool.
- Confirmed seeded categories and emotion profiles load.
- Confirmed a message can be created with the `Urgent` emotion profile.
- Confirmed a message segment can be created with the same `Urgent` emotion profile.
- Confirmed `Urgent` reports usage count `2`.
- Confirmed referenced-profile deactivation is blocked through the Local API.
- Confirmed referenced-profile deactivation is blocked through the UI and displays an actionable diagnostic.
- Confirmed no delete behavior, TTS behavior, speech preview, voice provider adapter, runtime playback, or audio playback behavior was introduced.
- Manual merge validation was not performed because `npm run test:workspace-v2` failed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
PR_26171_006-message-emotion-profile-management validation

Branch:
PASS pr/PR_26171_006-message-emotion-profile-management

Syntax:
PASS node --check src/dev-runtime/messages/messages-sqlite-service.mjs
PASS node --check toolbox/messages/messages.js
PASS node --check tests/playwright/tools/MessagesTool.spec.mjs

Targeted API/SQLite:
PASS direct service probe created a message and segment using Urgent, verified messageUsageCount=1, segmentUsageCount=1, usageCount=2, and verified referenced deactivation returns the expected 400 diagnostic.

Playwright:
PASS npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright --workers=1 --reporter=list
Result: 1 passed.

Workspace lane:
FAIL npm run test:workspace-v2
Failure file: tests/playwright/tools/RootToolsFutureState.spec.mjs
Failures:
- Toolbox accordion control-card count was 0.
- Header alphabetical expectation failed around Game Hub/Game Journey ordering.
- Non-Messages pages reported failed requests to session, platform banner, registry, and toolbox constants APIs.

Whitespace:
PASS git diff --check on touched implementation/test files. CRLF warnings only.

Disposition:
BLOCKED. PR_006 implementation is not merged because required workspace-v2 validation failed outside the Messages scope.
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# PR_26171_006-message-emotion-profile-management

## Branch Validation

- Branch: `pr/PR_26171_006-message-emotion-profile-management`
- Source: created after `main` contained commit `3dcb965a3`
- Status: PASS for branch setup; implementation branch remains unmerged because required workspace validation failed.

## Requirement Checklist

- PASS: Emotion profile payloads expose `messageUsageCount`, `segmentUsageCount`, `usageCount`, and `references`.
- PASS: Usage counts are computed from `messages_records.emotionProfileKey` and `messages_segments.emotionProfileKey`.
- PASS: Referenced emotion profiles cannot be deactivated.
- PASS: Blocked deactivation shows an actionable API/UI diagnostic.
- PASS: Emotion Profiles table displays usage count.
- PASS: Existing add/edit/Active behavior is preserved for unreferenced profiles.
- PASS: No delete endpoint was added.
- PASS: No Text To Speech, speech preview, voice adapter, runtime playback, or audio behavior was added.
- PASS: Theme V2 rules were preserved; no inline CSS, style block, inline script, or inline event handler was introduced.
- FAIL: Required `npm run test:workspace-v2` lane failed in existing `RootToolsFutureState.spec.mjs` coverage outside the Messages tool.

## Validation Lane Report

- PASS: `node --check src/dev-runtime/messages/messages-sqlite-service.mjs`
- PASS: `node --check toolbox/messages/messages.js`
- PASS: `node --check tests/playwright/tools/MessagesTool.spec.mjs`
- PASS: Direct SQLite/API usage-count and referenced-deactivation probe.
- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright --workers=1 --reporter=list`
- PASS: `git diff --check -- src/dev-runtime/messages/messages-sqlite-service.mjs toolbox/messages/index.html toolbox/messages/messages.js tests/playwright/tools/MessagesTool.spec.mjs`
- FAIL: `npm run test:workspace-v2`

## Workspace-V2 Failure Summary

`npm run test:workspace-v2` failed in `tests/playwright/tools/RootToolsFutureState.spec.mjs`:

- `root tools surface links current tool pages without old_* routes`: Toolbox accordion `.control-card` count was `0`.
- `common header renders primary navigation order across active pages`: existing alphabetical assertion expected `Game Hub` before `Game Journey`.
- `learn wireframe pages load with shared Theme V2 structure`: failed requests to `/api/session/current` and `/api/platform-settings/banner`.
- `tool template future-state page loads from root Theme V2 paths`: failed requests to `/api/session/current`, `/api/toolbox/registry/snapshot`, and `/api/platform-settings/banner`.
- `representative active tool pages align center cleanup and registry group colors`: failed requests to toolbox constants, session, platform banner, and registry APIs.

These failures are outside the PR_006 Messages emotion profile scope and were not fixed in this branch.

## Manual Validation Notes

- The Messages Playwright path creates a message using the `Urgent` profile and a segment using the same profile.
- The `Urgent` profile row displays usage count `2`.
- API deactivation of referenced `Urgent` returns HTTP 400 with the expected diagnostic.
- UI deactivation of referenced `Urgent` shows the expected diagnostic and leaves the profile Active.

## Samples Decision

- Full samples smoke was not run.
17 changes: 8 additions & 9 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/PR_26171_006-message-emotion-profile-management-manual-validation.md
docs_build/dev/reports/PR_26171_006-message-emotion-profile-management-validation.txt
docs_build/dev/reports/PR_26171_006-message-emotion-profile-management.md
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/PR_26171_003-game-journey-friendly-descriptions.md
docs_build/dev/reports/PR_26171_003-game-journey-friendly-descriptions-branch-validation.md
docs_build/dev/reports/PR_26171_003-game-journey-friendly-descriptions-manual-validation.md
docs_build/dev/reports/PR_26171_003-game-journey-friendly-descriptions-requirements-checklist.md
docs_build/dev/reports/PR_26171_003-game-journey-friendly-descriptions-validation-lane-report.md
tests/playwright/tools/RootToolsFutureState.spec.mjs
tests/playwright/tools/ToolboxRoutePages.spec.mjs
toolbox/tools-page-accordions.js
src/dev-runtime/messages/messages-sqlite-service.mjs
tests/playwright/tools/MessagesTool.spec.mjs
toolbox/messages/index.html
toolbox/messages/messages.js
Loading
Loading