Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# PR_26171_BETA_071-tts-profile-emotion-table Manual Validation Notes

Generated: 2026-06-20T22:26:42.301Z
Team ownership: BETA
Branch: pr/26171-BETA-071-tts-profile-emotion-table

## Manual Review

- Reviewed TTS Studio table markup in `toolbox/text-to-speech/index.html`; parent table already uses the required TTS Profiles columns.
- Reviewed TTS Studio rendering in `toolbox/text-to-speech/text2speech.js`; clicking a profile row opens the selected profile's Emotion Settings child table, and inline profile/emotion editors remain external-JS driven.
- Reviewed Message Studio compatibility coverage in `tests/playwright/tools/MessagesTool.spec.mjs`; the default TTS Profile dropdown and Message Parts TTS Profile dropdown remain validated.

## Automated Browser Coverage Used As Manual Proxy

- TTS Playwright validation clicked the default, Man Profile 1, and Woman Profile 2 rows and verified each selected profile exposes four emotion rows.
- TTS Playwright validation exercised Add/Edit Profile and Add/Edit Emotion inline paths.
- Message Studio Playwright validation exercised message-level and part-level TTS Profile dropdown behavior and playback routing.

## Not Performed

- No separate unscripted browser session was run beyond the targeted Playwright browser validations.
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# PR_26171_BETA_071-tts-profile-emotion-table Validation Report

Generated: 2026-06-20T22:26:42.301Z
Team ownership: BETA
Branch: pr/26171-BETA-071-tts-profile-emotion-table

## Results

- PASS: `npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs`
- 2 passed.
- PASS: `node --test tests/tools/Text2SpeechShell.test.mjs`
- 4 passed.
- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=off`
- 2 passed.
- PASS: `npm run test:workspace-v2`
- 5 workspace-contract Playwright tests passed.
- PASS: `git diff --check`
- No whitespace errors reported.

## Notes

- The Message Studio compatibility check used `--trace=off` to avoid the known trace artifact writer issue while keeping the browser assertions unchanged.
- Node emitted experimental SQLite warnings during Playwright runs; tests still passed.
- Workspace validation refreshed the standard generated validation report snapshots under `docs_build/dev/reports`.
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# PR_26171_BETA_071-tts-profile-emotion-table

Generated: 2026-06-20T22:26:42.301Z
Team ownership: BETA
Branch: pr/26171-BETA-071-tts-profile-emotion-table
Base HEAD: 78b642f70cf5698b611f2f8e1f6c6e18f9d73961
origin/main: 78b642f70cf5698b611f2f8e1f6c6e18f9d73961
Ahead/behind before commit: 0 0
Spec source: latest user request in Codex session; no repository BUILD_PR doc for PR_26171_BETA_071 was found by targeted search.

## Scope

- Implemented the missing TTS Studio parent/child table contract detail for Emotion Settings.
- Kept TTS Studio parent table as TTS Profiles.
- Kept profile row click expansion for selected-profile Emotion Settings.
- Kept inline Add/Edit Profile and Add/Edit Emotion behavior.
- Kept Message Studio TTS Profile dropdown compatibility.
- Kept Theme V2 and external JavaScript only.

## Code Changes

- Changed the TTS Studio Emotion Settings child-table column from `SSML-like Preset` to authoritative `Preset`.
- Updated the targeted TTS Playwright validation expectation to require the `Preset` child column.

## Existing Behavior Verified

- TTS Profiles columns remain: Profile Name, Voice, Language, Gender, Age, Emotion Count, Status, Actions.
- Emotion Settings child columns now read: Emotion, Pitch, Rate, Volume, Preset, Status, Actions.
- Default profile rows include Default Balanced Profile, Man Profile 1, and Woman Profile 2.
- Man Profile 1 and Woman Profile 2 each expose Neutral, Happy, Angry, and Scared emotion settings when selected.
- No separate Emotion Studio was introduced.
17 changes: 5 additions & 12 deletions docs_build/dev/reports/codex_changed_files.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-message-tts-ownership-checklist.md
docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-parent-child-table-checklist.md
docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment-validation.md
docs_build/dev/reports/PR_26171_BETA_069-message-tts-profile-contract-alignment.md
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-manual-validation-notes.md
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-validation.md
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table.md
docs_build/dev/reports/codex_changed_files.txt
docs_build/dev/reports/codex_review.diff
docs_build/dev/reports/coverage_changed_js_guardrail.txt
Expand All @@ -15,12 +13,9 @@ docs_build/dev/reports/incremental_validation_report.md
docs_build/dev/reports/lane_compilation_report.md
docs_build/dev/reports/lane_deduplication_report.md
docs_build/dev/reports/lane_input_validation_report.md
docs_build/dev/reports/lane_manifests/workspace-contract.json
docs_build/dev/reports/lane_runtime_optimization_report.md
docs_build/dev/reports/lane_snapshot_report.md
docs_build/dev/reports/lane_snapshots/workspace-contract.json
docs_build/dev/reports/lane_warm_start_report.md
docs_build/dev/reports/lane_warm_starts/workspace-contract.json
docs_build/dev/reports/monolith_trigger_removal_report.md
docs_build/dev/reports/persistent_lane_manifest_report.md
docs_build/dev/reports/playwright_discovery_ownership_report.md
Expand All @@ -36,7 +31,5 @@ docs_build/dev/reports/test_cleanup_routing_report.md
docs_build/dev/reports/testing_lane_execution_report.md
docs_build/dev/reports/validation_cache_report.md
docs_build/dev/reports/zero_browser_preflight_report.md
src/dev-runtime/messages/messages-sqlite-service.mjs
tests/playwright/tools/MessagesTool.spec.mjs
toolbox/messages/index.html
toolbox/messages/messages.js
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
toolbox/text-to-speech/text2speech.js
Loading
Loading