Skip to content

PR_26171_BETA_071 tts profile emotion table#28

Merged
ToolboxAid merged 1 commit into
mainfrom
pr/26171-BETA-071-tts-profile-emotion-table
Jun 20, 2026
Merged

PR_26171_BETA_071 tts profile emotion table#28
ToolboxAid merged 1 commit into
mainfrom
pr/26171-BETA-071-tts-profile-emotion-table

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

  • Align TTS Studio Emotion Settings child table header with the required Preset column name.
  • Update targeted TTS Playwright validation to assert the authoritative child column.
  • Preserve existing TTS Profiles parent table behavior, inline profile/emotion editors, and Message Studio TTS Profile dropdown compatibility.

Validation

  • PASS npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs
  • PASS node --test tests/tools/Text2SpeechShell.test.mjs
  • PASS npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=off
  • PASS npm run test:workspace-v2
  • PASS git diff --check

Reports

  • docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table.md
  • docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-validation.md
  • docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-manual-validation-notes.md
  • docs_build/dev/reports/codex_review.diff
  • docs_build/dev/reports/codex_changed_files.txt

Delta ZIP

  • tmp/PR_26171_BETA_071-tts-profile-emotion-table_delta.zip

@ToolboxAid ToolboxAid merged commit eaee83f into main Jun 20, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ff8afd4fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

await expect(page.getByRole("heading", { name: "Emotion Settings" })).toBeVisible();
await expect(page.getByRole("columnheader", { name: "Emotion", exact: true })).toBeVisible();
await expect(page.getByRole("columnheader", { name: "SSML-like Preset" })).toBeVisible();
await expect(page.getByRole("columnheader", { name: "Preset" })).toBeVisible();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require exact matching for the Preset header

In this validation path, getByRole(..., { name: "Preset" }) uses Playwright's default non-exact string matching, so the previous SSML-like Preset header still matches because it contains Preset. That means this test would pass even if the child-table contract regresses back to the old column name; the adjacent Emotion header already uses exact: true, and this assertion should too to actually enforce the required header text.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants