PR_26171_BETA_071 tts profile emotion table#28
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ff8afd4fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await expect(page.getByRole("heading", { name: "Emotion Settings" })).toBeVisible(); | ||
| await expect(page.getByRole("columnheader", { name: "Emotion", exact: true })).toBeVisible(); | ||
| await expect(page.getByRole("columnheader", { name: "SSML-like Preset" })).toBeVisible(); | ||
| await expect(page.getByRole("columnheader", { name: "Preset" })).toBeVisible(); |
There was a problem hiding this comment.
Require exact matching for the Preset header
In this validation path, getByRole(..., { name: "Preset" }) uses Playwright's default non-exact string matching, so the previous SSML-like Preset header still matches because it contains Preset. That means this test would pass even if the child-table contract regresses back to the old column name; the adjacent Emotion header already uses exact: true, and this assertion should too to actually enforce the required header text.
Useful? React with 👍 / 👎.
Summary
Presetcolumn name.Validation
npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjsnode --test tests/tools/Text2SpeechShell.test.mjsnpx playwright test tests/playwright/tools/MessagesTool.spec.mjs --trace=offnpm run test:workspace-v2git diff --checkReports
docs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table.mddocs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-validation.mddocs_build/dev/reports/PR_26171_BETA_071-tts-profile-emotion-table-manual-validation-notes.mddocs_build/dev/reports/codex_review.diffdocs_build/dev/reports/codex_changed_files.txtDelta ZIP
tmp/PR_26171_BETA_071-tts-profile-emotion-table_delta.zip