-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26179_OWNER_008-update-path-governance-final #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
821d54c
6831a2c
17600f9
d581b01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,25 +5,57 @@ Owner: OWNER | |
|
|
||
| ## Purpose | ||
|
|
||
| Define the target repository directory ownership model before the development workspace restructure chain begins. | ||
| Define the target repository directory ownership model for the post-restructure repository. | ||
|
|
||
| This document is governance only. It does not move runtime, UI, API, tests, or production files by itself. | ||
|
|
||
| ## Directory Ownership | ||
|
|
||
| - Repository root contains production/public product sections and standard repository configuration. | ||
| - Repository root contains production/public product sections and standard repository configuration only. | ||
| - `src/` contains deployable application code. | ||
| - `dev/` contains non-deployable build, test, bootstrap, governance, report, and local workspace items. | ||
| - `docs/` remains at root because it is production Docs & Help. | ||
| - `games/` remains at root because it is public game discovery. | ||
| - `toolbox/` remains at root because it is the Creator toolbox/workspace. | ||
| - Other public product roots such as `account/`, `admin/`, `legal/`, and `assets/` remain root-level product sections when present. | ||
|
|
||
| ## Final Src Layer Standard | ||
|
|
||
| The final `src/` ownership model is: | ||
|
|
||
| - `src/web/` for browser-facing deployable application modules used by public pages, account/admin surfaces, and Creator tools. | ||
| - `src/api-runtime/` for deployable API/runtime service modules that back the shared Browser -> API -> Postgres/R2 contract. | ||
| - `src/runtime/` for deployable game, tool, engine, and shared runtime capabilities. | ||
|
|
||
| Transition rule: | ||
|
|
||
| - Existing top-level `src/advanced/`, `src/api/`, `src/dev-runtime/`, `src/engine/`, `src/shared/`, and `src/tools/` directories are legacy transition buckets until explicit migration PRs move them. | ||
| - Do not add new top-level `src/` layer names outside `src/web/`, `src/api-runtime/`, or `src/runtime/` without OWNER approval. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This new rule is not covered by the canonical-structure validation that the PR reports as passing: Useful? React with 👍 / 👎. |
||
| - Do not use team names in runtime source filenames. | ||
|
|
||
| ## Development Workspace Paths | ||
|
|
||
| - `dev/docs_build/` owns active development governance, Project Instructions, PR workflow material, validation reports, and generated documentation-workspace artifacts. | ||
| - `dev/docs_build/` owns active development governance, Project Instructions, and PR workflow material. | ||
| - `dev/reports/` owns generated reports using flat filenames. | ||
| - `dev/tests/` owns non-deployable test suites. | ||
| - `dev/scripts/` owns development-only scripts and runners. | ||
| - `dev/config/` owns development-only runner and tooling configuration. | ||
| - `dev/workspace/artifacts/` owns generated non-report artifacts and ignored local temporary workspace output. | ||
| - `dev/archive/` owns historical development reference material that is not active governance. | ||
| - `dev/project-instructions/` is deprecated reference only when retained; it must point to `dev/docs_build/dev/ProjectInstructions/`. | ||
| - Root `docs_build/`, root `archive/`, and root `project-instructions/` are not active workspace locations after the governance workspace move. | ||
| - Root `docs_build/`, root `tests/`, root `archive/`, root `tmp/`, and root `project-instructions/` are not active workspace locations after the restructure. | ||
| - Root `tmp/` may remain ignored as legacy local scratch only; required Codex ZIPs and generated temporary artifacts belong under `dev/workspace/artifacts/tmp/`. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
For BUILD work in this repo, the tracked Useful? React with 👍 / 👎. |
||
|
|
||
| ## Legacy Reference Exceptions | ||
|
|
||
| Path references to old root `docs_build/`, `tests/`, `archive/`, or `tmp/` locations are allowed only when they are: | ||
|
|
||
| - historical/reference content under `dev/archive/` or `dev/docs_build/dev/PR/reference/` | ||
| - explicit legacy exception notes in active governance | ||
| - ignore rules that keep obsolete local scratch from entering commits | ||
| - migration reports documenting the old path and its replacement | ||
|
|
||
| Active commands, templates, and Project Instructions must use the final `dev/`, `dev/reports/`, and `dev/workspace/artifacts/` paths. | ||
|
|
||
| ## Creator Data Boundary | ||
|
|
||
|
|
@@ -42,3 +74,5 @@ This document is governance only. It does not move runtime, UI, API, tests, or p | |
| ## PR Chain Boundary | ||
|
|
||
| The development workspace restructure must proceed through sequential scoped PRs. A PR may only move or update the paths named in its purpose. | ||
|
|
||
| Final path-governance PRs may document target paths and legacy exceptions, but they must not move deployable application code unless explicitly scoped. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # PR_26179_OWNER_008-update-path-governance-final | ||
|
|
||
| Updated: 2026-06-27T20:36:34.395Z | ||
| Branch: PR_26179_OWNER_008-update-path-governance-final | ||
| ZIP: dev/workspace/artifacts/tmp/PR_26179_OWNER_008-update-path-governance-final_delta.zip | ||
|
|
||
| ## Purpose | ||
|
|
||
| Finalize path governance after the dev workspace restructure chain and correct the PR #243 GitHub Actions platform-validation script path after the root `scripts/` directory moved to `dev/scripts/`. | ||
|
|
||
| ## Changes | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
In this commit, Useful? React with 👍 / 👎. |
||
| - Updated `.github/workflows/platform-validation.yml` from `node ./scripts/run-platform-validation-suite.mjs` to `node ./dev/scripts/run-platform-validation-suite.mjs`. | ||
| - Confirmed no other GitHub Actions workflow references still call moved root `./scripts/` paths. | ||
| - Preserved PR_008 governance-only path standard updates. | ||
|
|
||
| ## Validation Summary | ||
|
|
||
| | Status | Item | Notes | | ||
| | --- | --- | --- | | ||
| | PASS | Current branch | PR_26179_OWNER_008-update-path-governance-final | | ||
| | PASS | GitHub Actions platform-validation path | .github/workflows/platform-validation.yml uses node ./dev/scripts/run-platform-validation-suite.mjs | | ||
| | PASS | Old moved root scripts path grep | No .github workflow references to node ./scripts/, run: ./scripts/, or standalone ./scripts/ remain. | | ||
| | PASS | npm run validate:canonical-structure | passed | | ||
| | PASS | git diff --check | passed | | ||
| | PASS | node ./dev/scripts/run-platform-validation-suite.mjs | passed locally: 8/8 deterministic platform scenarios; CI gate green message emitted | | ||
| | PASS | Runtime/product scope | No runtime/business logic, production pages, or routes modified. | | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # PR_26179_OWNER_008-update-path-governance-final Branch Validation | ||
|
|
||
| | Status | Item | Notes | | ||
| | --- | --- | --- | | ||
| | PASS | Current branch | PR_26179_OWNER_008-update-path-governance-final | | ||
| | PASS | GitHub Actions platform-validation path | .github/workflows/platform-validation.yml uses node ./dev/scripts/run-platform-validation-suite.mjs | | ||
|
|
||
| Result: PASS |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # PR_26179_OWNER_008-update-path-governance-final Manual Validation Notes | ||
|
|
||
| - Confirmed branch: PR_26179_OWNER_008-update-path-governance-final | ||
| - Worktree was clean at start before the workflow patch. | ||
| - Changed only `.github/workflows/platform-validation.yml` and PR_008 report artifacts for the CI path correction. | ||
| - Confirmed no old root `./scripts/` GitHub Actions workflow calls remain. | ||
| - Ran `node ./dev/scripts/run-platform-validation-suite.mjs`; local platform validation passed 8/8 scenarios and emitted CI gate green. | ||
| - Ran `npm run validate:canonical-structure`; passed. | ||
| - Ran `git diff --check`; passed. | ||
| - Repo-structured ZIP path: `dev/workspace/artifacts/tmp/PR_26179_OWNER_008-update-path-governance-final_delta.zip` |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # PR_26179_OWNER_008-update-path-governance-final Requirement Checklist | ||
|
|
||
| | Status | Item | Notes | | ||
| | --- | --- | --- | | ||
| | PASS | Find workflow references to node ./scripts/run-platform-validation-suite.mjs | Located one reference in .github/workflows/platform-validation.yml. | | ||
| | PASS | Update to node ./dev/scripts/run-platform-validation-suite.mjs | Updated only the moved CI script path. | | ||
| | PASS | Check for other GitHub Actions moved root scripts/ references | Targeted grep found no remaining old root ./scripts/ workflow calls. | | ||
| | PASS | Do not move files | No files moved. | | ||
| | PASS | Do not change runtime behavior | Only GitHub Actions workflow path and reports changed. | | ||
| | PASS | Do not change production pages | No production page files changed. | | ||
|
|
||
| Result: PASS |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # PR_26179_OWNER_008-update-path-governance-final Validation Lane | ||
|
|
||
| | Status | Item | Notes | | ||
| | --- | --- | --- | | ||
| | PASS | Old moved root scripts path grep | No .github workflow references to node ./scripts/, run: ./scripts/, or standalone ./scripts/ remain. | | ||
| | PASS | npm run validate:canonical-structure | passed | | ||
| | PASS | git diff --check | passed | | ||
| | PASS | node ./dev/scripts/run-platform-validation-suite.mjs | passed locally: 8/8 deterministic platform scenarios; CI gate green message emitted | | ||
| | PASS | Runtime/product scope | No runtime/business logic, production pages, or routes modified. | | ||
|
|
||
| Scoped validation result: PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This canonical root list omits several tracked public page roots that already exist in this commit (
community/,company/,learn/,marketplace/,memberships/, andowner/, each with HTML entrypoints). Because the same document says new development follows the canonical structure, future governance/cleanup work using this list as the source of truth can incorrectly treat those current product sections as non-canonical even though this PR neither moves nor deprecates them; include them here or explicitly list them as legacy exceptions.Useful? React with 👍 / 👎.